Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 290143005: Update default WriteFile permissions to 0640 (Closed)

Created:
6 years, 7 months ago by aurimas (slooooooooow)
Modified:
6 years, 4 months ago
Reviewers:
Yaron, brettw
CC:
chromium-reviews, erikwright+watch_chromium.org, Lei Zhang
Visibility:
Public.

Description

Update default WriteFile permissions to 0640 BUG=362887 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/file_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
aurimas (slooooooooow)
Hey Yaron, PTAL. Aurimas
6 years, 7 months ago (2014-05-16 18:05:27 UTC) #1
Yaron
this seems reasonable to me based on discussion but ranges wider than just android. +Brett ...
6 years, 7 months ago (2014-05-19 18:35:58 UTC) #2
aurimas (slooooooooow)
On 2014/05/19 18:35:58, Yaron wrote: > this seems reasonable to me based on discussion but ...
6 years, 6 months ago (2014-06-03 00:10:13 UTC) #3
brettw
These permissions make intuitive sense to me, 0666 seems like a bad idea. LGTM
6 years, 6 months ago (2014-06-03 17:28:49 UTC) #4
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 6 months ago (2014-06-03 17:29:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/290143005/1
6 years, 6 months ago (2014-06-03 17:30:45 UTC) #6
commit-bot: I haz the power
Change committed as 274593
6 years, 6 months ago (2014-06-03 19:35:09 UTC) #7
Lei Zhang
6 years, 4 months ago (2014-08-15 19:35:03 UTC) #8
Message was sent while issue was closed.
I can't see the bug so I have no idea why this was done, but did you really have
to do this? creat() takes the process's umask into account. So given a system
where the umask is 0027,

creat("perm640", 0640);

and

creat("perm666", 0666);

creates two files both with 0640 as their permissions.

Powered by Google App Engine
This is Rietveld 408576698