Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 290143004: [Android] Do not consume ACTION_CANCEL and ACTION_UP on the menu button. (Closed)

Created:
6 years, 7 months ago by aurimas (slooooooooow)
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[Android] Do not consume ACTION_CANCEL and ACTION_UP on the menu button. NOTRY=true BUG=369680 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271069

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
aurimas (slooooooooow)
Hey Kibeom, PTAL at this CL. Aurimas
6 years, 7 months ago (2014-05-16 17:36:25 UTC) #1
Kibeom Kim (inactive)
LGTM, adding tedchoc for a committer approval. https://chromiumcodereview.appspot.com/290143004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java File chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java (right): https://chromiumcodereview.appspot.com/290143004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java#newcode106 chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java:106: boolean isMenuButtonReleased ...
6 years, 7 months ago (2014-05-16 18:02:41 UTC) #2
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/290143004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java File chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java (right): https://chromiumcodereview.appspot.com/290143004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java#newcode106 chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java:106: boolean isMenuButtonReleased = false; On 2014/05/16 18:02:41, Kibeom Kim ...
6 years, 7 months ago (2014-05-16 18:10:32 UTC) #3
Ted C
lgtm
6 years, 7 months ago (2014-05-16 18:19:16 UTC) #4
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 7 months ago (2014-05-16 18:49:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/290143004/20001
6 years, 7 months ago (2014-05-16 18:50:45 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 18:53:29 UTC) #7
Message was sent while issue was closed. 
Change committed as 271069

Powered by Google App Engine
This is Rietveld 408576698