Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2187)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_util.h

Issue 2901383002: Buffer cross frame paint timing updates. (Closed)
Patch Set: address comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_util.h
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_util.h b/chrome/browser/page_load_metrics/page_load_metrics_util.h
index 1e6af5716c95d5d73e6b3f7ac37c3955a13d8c08..a81c04320fb818834c3187b6d018ed0674264375 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_util.h
+++ b/chrome/browser/page_load_metrics/page_load_metrics_util.h
@@ -9,6 +9,7 @@
#include "base/optional.h"
#include "base/time/time.h"
#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
+#include "chrome/common/page_load_metrics/page_load_metrics_util.h"
#include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h"
// Up to 10 minutes, with 100 buckets.
@@ -118,34 +119,12 @@ base::Optional<base::TimeDelta> GetInitialForegroundDuration(
const PageLoadExtraInfo& info,
base::TimeTicks app_background_time);
-// Returns the minimum value of the optional TimeDeltas, if both values are
-// set. Otherwise, if one value is set, returns that value. Otherwise, returns
-// an unset value.
-base::Optional<base::TimeDelta> OptionalMin(
- const base::Optional<base::TimeDelta>& a,
- const base::Optional<base::TimeDelta>& b);
-
// Whether the given loading behavior was observed in any frame (either the main
// frame or a subframe).
bool DidObserveLoadingBehaviorInAnyFrame(
const page_load_metrics::PageLoadExtraInfo& info,
blink::WebLoadingBehaviorFlag behavior);
-// Whether the given url has a google hostname.
-bool IsGoogleHostname(const GURL& url);
-
-// If the given hostname is a google hostname, returns the portion of the
-// hostname before the google hostname. Otherwise, returns an unset optional
-// value.
-//
-// For example:
-// https://example.com/foo => returns an unset optional value
-// https://google.com/foo => returns ''
-// https://www.google.com/foo => returns 'www'
-// https://news.google.com/foo => returns 'news'
-// https://a.b.c.google.com/foo => returns 'a.b.c'
-base::Optional<std::string> GetGoogleHostnamePrefix(const GURL& url);
-
} // namespace page_load_metrics
#endif // CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_METRICS_UTIL_H_

Powered by Google App Engine
This is Rietveld 408576698