Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1394)

Unified Diff: third_party/WebKit/Source/platform/plugins/PluginListBuilder.cpp

Issue 2901353002: Move blink::PluginData, blink::PluginInfo, blink::MimeTypeInfo to oilpan heap. (Closed)
Patch Set: nits, remove dead code Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/plugins/PluginListBuilder.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/plugins/PluginListBuilder.cpp
diff --git a/third_party/WebKit/Source/platform/plugins/PluginListBuilder.cpp b/third_party/WebKit/Source/platform/plugins/PluginListBuilder.cpp
index e1fb4e132c79b655d5dfcd4451f483e122d71681..75fde27f592f84981085e4e06be1308016891a14 100644
--- a/third_party/WebKit/Source/platform/plugins/PluginListBuilder.cpp
+++ b/third_party/WebKit/Source/platform/plugins/PluginListBuilder.cpp
@@ -37,25 +37,25 @@ namespace blink {
void PluginListBuilder::AddPlugin(const WebString& name,
const WebString& description,
const WebString& file_name) {
- PluginInfo info;
- info.name = name;
- info.desc = description;
- info.file = file_name;
- results_->push_back(info);
+ if (results_)
+ results_->push_back(new PluginInfo(name, file_name, description));
}
void PluginListBuilder::AddMediaTypeToLastPlugin(const WebString& name,
const WebString& description) {
- MimeClassInfo info;
- info.type = name;
- info.desc = description;
- results_->back().mimes.push_back(info);
+ if (results_) {
+ MimeClassInfo* info =
+ new MimeClassInfo(name, description, *results_->back());
+ results_->back()->AddMimeType(info);
+ }
}
void PluginListBuilder::AddFileExtensionToLastMediaType(
const WebString& extension) {
- MimeClassInfo& info = results_->back().mimes.back();
- info.extensions.push_back(extension);
+ if (results_) {
+ MimeClassInfo& info = *results_->back()->mimes_.back();
+ info.extensions_.push_back(extension);
+ }
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/platform/plugins/PluginListBuilder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698