Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: third_party/WebKit/Source/modules/plugins/DOMPlugin.h

Issue 2901353002: Move blink::PluginData, blink::PluginInfo, blink::MimeTypeInfo to oilpan heap. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/plugins/DOMPlugin.h
diff --git a/third_party/WebKit/Source/modules/plugins/DOMPlugin.h b/third_party/WebKit/Source/modules/plugins/DOMPlugin.h
index d859c77002119934445a5e12db6e1924df270e72..9c80d1f69e40772f75352b010922323cd8ee58bc 100644
--- a/third_party/WebKit/Source/modules/plugins/DOMPlugin.h
+++ b/third_party/WebKit/Source/modules/plugins/DOMPlugin.h
@@ -29,8 +29,6 @@
namespace blink {
-class PluginData;
-
class DOMPlugin final : public GarbageCollectedFinalized<DOMPlugin>,
public ScriptWrappable,
public ContextClient {
@@ -38,10 +36,8 @@ class DOMPlugin final : public GarbageCollectedFinalized<DOMPlugin>,
DEFINE_WRAPPERTYPEINFO();
public:
- static DOMPlugin* Create(PluginData* plugin_data,
- LocalFrame* frame,
- unsigned index) {
- return new DOMPlugin(plugin_data, frame, index);
+ static DOMPlugin* Create(LocalFrame* frame, const PluginInfo* plugin_info) {
tkent 2017/05/25 00:10:32 Make the second argument |const PluginInfo&| to en
lfg 2017/05/25 01:42:40 Done.
+ return new DOMPlugin(frame, plugin_info);
}
virtual ~DOMPlugin();
@@ -57,14 +53,9 @@ class DOMPlugin final : public GarbageCollectedFinalized<DOMPlugin>,
DECLARE_VIRTUAL_TRACE();
private:
- DOMPlugin(PluginData*, LocalFrame*, unsigned index);
-
- const PluginInfo& GetPluginInfo() const {
- return plugin_data_->Plugins()[index_];
- }
+ explicit DOMPlugin(LocalFrame*, const PluginInfo*);
tkent 2017/05/25 00:10:32 Do not add |explicit|. Make the second argument |c
lfg 2017/05/25 01:42:40 Done.
- RefPtr<PluginData> plugin_data_;
- unsigned index_;
+ Member<const PluginInfo> plugin_info_;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698