Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: third_party/WebKit/Source/modules/plugins/DOMMimeType.h

Issue 2901353002: Move blink::PluginData, blink::PluginInfo, blink::MimeTypeInfo to oilpan heap. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/plugins/DOMMimeType.h
diff --git a/third_party/WebKit/Source/modules/plugins/DOMMimeType.h b/third_party/WebKit/Source/modules/plugins/DOMMimeType.h
index 14b4b4458c678c96468dd6865bcef61c3b8d2851..7ac217e7c75713045d97ad5da4e0257544a761f4 100644
--- a/third_party/WebKit/Source/modules/plugins/DOMMimeType.h
+++ b/third_party/WebKit/Source/modules/plugins/DOMMimeType.h
@@ -39,10 +39,9 @@ class DOMMimeType final : public GarbageCollectedFinalized<DOMMimeType>,
DEFINE_WRAPPERTYPEINFO();
public:
- static DOMMimeType* Create(PassRefPtr<PluginData> plugin_data,
- LocalFrame* frame,
- unsigned index) {
- return new DOMMimeType(std::move(plugin_data), frame, index);
+ static DOMMimeType* Create(LocalFrame* frame,
+ const MimeClassInfo* mime_class_info) {
tkent 2017/05/25 00:10:31 Make the argument "const MimeClassInfo&" to ensure
lfg 2017/05/25 01:42:40 Done.
+ return new DOMMimeType(frame, mime_class_info);
}
virtual ~DOMMimeType();
@@ -54,14 +53,9 @@ class DOMMimeType final : public GarbageCollectedFinalized<DOMMimeType>,
DECLARE_VIRTUAL_TRACE();
private:
- DOMMimeType(PassRefPtr<PluginData>, LocalFrame*, unsigned index);
+ explicit DOMMimeType(LocalFrame*, const MimeClassInfo*);
tkent 2017/05/25 00:10:32 Do not add |explicit|. Make the second argument |c
lfg 2017/05/25 01:42:40 Done.
- const MimeClassInfo& GetMimeClassInfo() const {
- return plugin_data_->Mimes()[index_];
- }
-
- RefPtr<PluginData> plugin_data_;
- unsigned index_;
+ Member<const MimeClassInfo> mime_class_info_;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698