Issue 290133004: Print promotion rate and semi-space copy rate in --trace-gc-nvp.

Issue 290133004: Print promotion rate and semi-space copy rate in --trace-gc-nvp. (Closed)

Created:
6 years, 7 months ago by Hannes Payer (out of office)

Modified:
6 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Print promotion rate and semi-space copy rate in --trace-gc-nvp. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21381

Patch Set 4 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -19 lines)			Patch
M	src/heap.h	View	1 2 3	4 chunks	+14 lines, -9 lines	0 comments	Download
M	src/heap.cc	View	1 2 3	7 chunks	+25 lines, -8 lines	0 comments	Download
M	src/mark-compact.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM, just nits. https://codereview.chromium.org/290133004/diff/20001/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/290133004/diff/20001/src/heap.cc#newcode2059 src/heap.cc:2059: if (FLAG_trace_gc) { nit: This makes ...

6 years, 7 months ago (2014-05-16 11:30:37 UTC) #2

Hannes Payer (out of office)

https://codereview.chromium.org/290133004/diff/20001/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/290133004/diff/20001/src/heap.cc#newcode2059 src/heap.cc:2059: if (FLAG_trace_gc) { On 2014/05/16 11:30:37, Michael Starzinger wrote: ...

6 years, 7 months ago (2014-05-20 09:29:14 UTC) #3

Hannes Payer (out of office)

6 years, 7 months ago (2014-05-20 09:53:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r21381 (presubmit successful).

Expand Messages | Collapse Messages