add _CompileTimeError error to dart2js patch

add _CompileTimeError error to dart2js patch

See https://github.com/dart-lang/sdk/issues/29661 for context

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/80942f15cf4b3bf28692bab560370d25e2711763

[Siggi Cherem (dart-lang), 2017-05-24 19:49:08]

Description was changed from

==========
add _CompileTimeError error to dart2js patch

BUG=
==========

to

==========
add _CompileTimeError error to dart2js patch

See https://github.com/dart-lang/sdk/issues/29661 for context
==========

[Siggi Cherem (dart-lang), 2017-05-24 19:49:17]

sigmund@google.com changed reviewers:
+ ahe@google.com, sra@google.com

[ahe, 2017-05-24 19:53:31]

lgtm

https://codereview.chromium.org/2901323002/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/core_patch.dart (right):

https://codereview.chromium.org/2901323002/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/core_patch.dart:611:
_CompileTimeError(this._errorMsg);
Consider adding this body:

{ JS("", "debug"); }

[Siggi Cherem (dart-lang), 2017-05-24 20:14:18]

thanks!

https://codereview.chromium.org/2901323002/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/core_patch.dart (right):

https://codereview.chromium.org/2901323002/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/core_patch.dart:611:
_CompileTimeError(this._errorMsg);
On 2017/05/24 19:53:31, ahe wrote:
> Consider adding this body:
> 
> { JS("", "debug"); }

not sure I follow - did you mean 'debugger' to set a breakpoint preemptively?

If so - I'm not convinced, I think without it we give users more flexibility.
For exampale, with `debugger`, the only way to proceed is to skip each debugger
call by hand. Without it users can use stop-on-unhandled-exceptions if they want
to stop, or disable that if just want to see errors in the console.

[ahe, 2017-05-24 20:19:12]

https://codereview.chromium.org/2901323002/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/core_patch.dart (right):

https://codereview.chromium.org/2901323002/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/core_patch.dart:611:
_CompileTimeError(this._errorMsg);
On 2017/05/24 20:14:18, Siggi Cherem (dart-lang) wrote:
> On 2017/05/24 19:53:31, ahe wrote:
> > Consider adding this body:
> > 
> > { JS("", "debug"); }
> 
> not sure I follow - did you mean 'debugger' to set a breakpoint preemptively?
> 
> If so - I'm not convinced, I think without it we give users more flexibility.
> For exampale, with `debugger`, the only way to proceed is to skip each
debugger
> call by hand. Without it users can use stop-on-unhandled-exceptions if they
want
> to stop, or disable that if just want to see errors in the console. 

Yes, I meant "debugger". This is what the specification says:

If an uncaught compile-time error occurs within the code of a running isolate
$A$, $A$ is immediately suspended.

Rationale: you don't want to be able to catch a compile-time error as a regular
exception.

[Siggi Cherem (dart-lang), 2017-05-24 20:48:19]

On 2017/05/24 20:19:12, ahe wrote:
>
https://codereview.chromium.org/2901323002/diff/1/sdk/lib/_internal/js_runtim...
> File sdk/lib/_internal/js_runtime/lib/core_patch.dart (right):
> 
>
https://codereview.chromium.org/2901323002/diff/1/sdk/lib/_internal/js_runtim...
> sdk/lib/_internal/js_runtime/lib/core_patch.dart:611:
> _CompileTimeError(this._errorMsg);
> On 2017/05/24 20:14:18, Siggi Cherem (dart-lang) wrote:
> > On 2017/05/24 19:53:31, ahe wrote:
> > > Consider adding this body:
> > > 
> > > { JS("", "debug"); }
> > 
> > not sure I follow - did you mean 'debugger' to set a breakpoint
preemptively?
> > 
> > If so - I'm not convinced, I think without it we give users more
flexibility.
> > For exampale, with `debugger`, the only way to proceed is to skip each
> debugger
> > call by hand. Without it users can use stop-on-unhandled-exceptions if they
> want
> > to stop, or disable that if just want to see errors in the console. 
> 
> Yes, I meant "debugger". This is what the specification says:
> 
> If an uncaught compile-time error occurs within the code of a running isolate
> $A$, $A$ is immediately suspended.
> 
> Rationale: you don't want to be able to catch a compile-time error as a
regular
> exception.

I see what you mean. Let me consult with the rest of the team and the DDC folks
to make sure we do something consistent here. I'll land with a TODO for now to
unblock you

[Siggi Cherem (dart-lang), 2017-05-24 20:52:38]

Description was changed from

==========
add _CompileTimeError error to dart2js patch

See https://github.com/dart-lang/sdk/issues/29661 for context
==========

to

==========
add _CompileTimeError error to dart2js patch

See https://github.com/dart-lang/sdk/issues/29661 for context

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/80942f15cf4b3bf28692bab560370d25e2711763
==========

[Siggi Cherem (dart-lang), 2017-05-24 20:52:39]

Committed patchset #1 (id:1) manually as
80942f15cf4b3bf28692bab560370d25e2711763 (presubmit successful).

[ahe, 2017-05-24 21:08:11]

On 2017/05/24 20:48:19, Siggi Cherem (dart-lang) wrote:
> I see what you mean. Let me consult with the rest of the team and the DDC
folks
> to make sure we do something consistent here. I'll land with a TODO for now to
> unblock you

Thank you!