chromeos: Remove TrayBubbleView::Delegate::OnBeforeBubbleWidgetInit

ui/views/bubble/bubble_dialog_delegate.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_BUBBLE_BUBBLE_DIALOG_DELEGATE_H_
 #define UI_VIEWS_BUBBLE_BUBBLE_DIALOG_DELEGATE_H_
 
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "ui/views/bubble/bubble_border.h"
@@ skipping 81 matching lines @@
   bool accept_events() const { return accept_events_; }
   void set_accept_events(bool accept_events) { accept_events_ = accept_events; }
 
   bool adjust_if_offscreen() const { return adjust_if_offscreen_; }
   void set_adjust_if_offscreen(bool adjust) { adjust_if_offscreen_ = adjust; }
 
   // Get the arrow's anchor rect in screen space.
   virtual gfx::Rect GetAnchorRect() const;
 
   // Allows delegates to provide custom parameters before widget initialization.
-  // For example, mus needs to set a custom ui::Window* parent.
   virtual void OnBeforeBubbleWidgetInit(Widget::InitParams* params,

[msw, 2017/05/24 18:04:38]

q: We should be able to eliminate this soon, if not now, right?

[James Cook, 2017/05/24 18:27:04]

Unfortunately this one is still used to do things like set custom shadows,
allocate a new widget for the app list, etc. We might be able to remove it, but
it's not trivial.

[msw, 2017/05/24 18:48:36]

Acknowledged. Sounds worth pursuing later on.

                                         Widget* widget) const;
 
   // Sets |margins_| to a default picked for smaller bubbles.
   void UseCompactMargins();
 
   // Sets the bubble alignment relative to the anchor. This may only be called
   // after calling CreateBubble.
   void SetAlignment(BubbleBorder::BubbleAlignment alignment);
 
   // Sets the bubble arrow paint type.
@@ skipping 93 matching lines @@
 
   // Parent native window of the bubble.
   gfx::NativeView parent_window_;
 
   DISALLOW_COPY_AND_ASSIGN(BubbleDialogDelegateView);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_BUBBLE_BUBBLE_DELEGATE2_H_