Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 290123004: Canonicalize user ID passed via chromeos::switches::kLoginUser (Closed)

Created:
6 years, 7 months ago by bartfab (slow)
Modified:
6 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Canonicalize user ID passed via chromeos::switches::kLoginUser Chrome treats the user ID passed in via chromeos::switches::kLoginUser as if someone had authenticated against GAIA using this ID. During GAIA authentication, the user ID is canonicalized. If authentication is short-circuited using this switch, the user ID should thus be canonicalized as well. BUG=367847 TEST=None TBR=stevenjb (chrome/browser/extensions/api/networking_private/networking_private_apitest.cc) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271042

Patch Set 1 #

Patch Set 2 : Fix ScreenlockPrivateApiTest.AuthType. #

Patch Set 3 : Fix ExtensionNetworkingPrivateApiTestInstantiation tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -12 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/extensions/screenlock_private_apitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/helper.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/helper.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_apitest.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bartfab (slow)
Hi Nikita, Could you take a look please?
6 years, 7 months ago (2014-05-16 11:41:00 UTC) #1
Nikita (slow)
lgtm
6 years, 7 months ago (2014-05-16 11:49:10 UTC) #2
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 7 months ago (2014-05-16 11:51:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/290123004/20001
6 years, 7 months ago (2014-05-16 11:52:16 UTC) #4
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 7 months ago (2014-05-16 13:26:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/290123004/40001
6 years, 7 months ago (2014-05-16 13:26:51 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 15:06:41 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 17:33:53 UTC) #8
Message was sent while issue was closed.
Change committed as 271042

Powered by Google App Engine
This is Rietveld 408576698