third_party/WebKit/Source/core/frame/LocalDOMWindow.h - Issue 2901203002: Rename VisualViewport properties to match updated spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.h

Issue 2901203002: Rename VisualViewport properties to match updated spec (Closed)

Patch Set: Make methods const Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.h

diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.h b/third_party/WebKit/Source/core/frame/LocalDOMWindow.h

index 0646f6c8f09294379b41a37d4157e590939e3e4f..2ad0b6ac3b8bd053487bd313b477634bc2ffa539 100644

--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.h

+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.h

@@ -146,7 +146,7 @@ class CORE_EXPORT LocalDOMWindow final : public DOMWindow,

double pageXOffset() const { return scrollX(); }

double pageYOffset() const { return scrollY(); }

- DOMVisualViewport* visualViewport();

+ DOMVisualViewport* view();

const AtomicString& name() const;

void setName(const AtomicString&);

@@ -344,7 +344,7 @@ class CORE_EXPORT LocalDOMWindow final : public DOMWindow,

void ClearDocument();

Member<Document> document_;

- Member<DOMVisualViewport> visual_viewport_;

+ Member<DOMVisualViewport> view_;

TaskRunnerTimer<LocalDOMWindow> unused_preloads_timer_;

bool should_print_when_finished_loading_;