Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/core/frame/VisualViewport.h

Issue 2901203002: Rename VisualViewport properties to match updated spec (Closed)
Patch Set: Removed changes to VisualViewport type Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/VisualViewport.h
diff --git a/third_party/WebKit/Source/core/frame/VisualViewport.h b/third_party/WebKit/Source/core/frame/VisualViewport.h
index bf82d7db164455a33336e6af1241d8f4f45ec3e6..cb29b570f316ce4374b971dfa7c0f4efab366c18 100644
--- a/third_party/WebKit/Source/core/frame/VisualViewport.h
+++ b/third_party/WebKit/Source/core/frame/VisualViewport.h
@@ -217,11 +217,11 @@ class CORE_EXPORT VisualViewport final
RefPtr<WebTaskRunner> GetTimerTaskRunner() const final;
// Visual Viewport API implementation.
- double ScrollLeft();
- double ScrollTop();
- double ClientWidth();
- double ClientHeight();
- double PageScale();
+ double OffsetLeft();
dtapuska 2017/05/24 17:21:40 Should these be const?
bokan 2017/05/24 19:17:14 Done.
+ double OffsetTop();
+ double Width();
+ double Height();
+ double ScaleForVisualViewport();
// Used for gathering data on user pinch-zoom statistics.
void UserDidChangeScale();

Powered by Google App Engine
This is Rietveld 408576698