third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html - Issue 2901203002: Rename VisualViewport properties to match updated spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html

Issue 2901203002: Rename VisualViewport properties to match updated spec (Closed)

Patch Set: Removed changes to VisualViewport type Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-custom-scrollbars.html ('k') | third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-iframe.html » ('j') | third_party/WebKit/Source/core/frame/DOMVisualViewport.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html b/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html

index a4e4dadb633df1488779b04e0b8aee7491dad964..2e6405b8f28082610ffe4cf4d5456a7e2971b27f 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html

@@ -14,7 +14,7 @@

var scrollbarHeightCSSPixels = 15 / pageScaleFactor;

function viewport() {

- return window.visualViewport;

+ return window.view;

}

async_test(function(t) {

@@ -24,15 +24,15 @@

internals.setPageScaleFactor(pageScaleFactor);

// Verify viewport dimensions exclude scrollbar.

- assert_equals(viewport().clientWidth, 800 / pageScaleFactor - scrollbarWidthCSSPixels);

- assert_equals(viewport().clientHeight, 600 / pageScaleFactor - scrollbarHeightCSSPixels);

+ assert_equals(viewport().width, 800 / pageScaleFactor - scrollbarWidthCSSPixels);

+ assert_equals(viewport().height, 600 / pageScaleFactor - scrollbarHeightCSSPixels);

// Apply browser zoom.

window.internals.setZoomFactor(browserZoomFactor);

// Verify scrollbar exclusion with browser zoom.

- assert_equals(viewport().clientWidth, 800 / pageScaleFactor / browserZoomFactor - scrollbarWidthCSSPixels);

- assert_equals(viewport().clientHeight, 600 / pageScaleFactor / browserZoomFactor - scrollbarHeightCSSPixels);

+ assert_equals(viewport().width, 800 / pageScaleFactor / browserZoomFactor - scrollbarWidthCSSPixels);

+ assert_equals(viewport().height, 600 / pageScaleFactor / browserZoomFactor - scrollbarHeightCSSPixels);

t.done();

});

}, 'Verify viewport dimensions exclude scrollbars.');