Move RedirectChromeLogging to src/chromeos.

chrome/common/logging_chrome.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_LOGGING_CHROME_H_
 #define CHROME_COMMON_LOGGING_CHROME_H_
 
 #include "base/logging.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
@@ skipping 14 matching lines @@
 // they will delete each others' logs.
 //
 // XXX
 // Setting suppress_error_dialogs to true disables any dialogs that would
 // normally appear for assertions and crashes, and makes any catchable
 // errors (namely assertions) available via GetSilencedErrorCount()
 // and GetSilencedError().
 void InitChromeLogging(const base::CommandLine& command_line,
                        OldFileDeletionState delete_old_log_file);
 
+LoggingDestination DetermineLogMode(const base::CommandLine& command_line);

[sky, 2017/05/25 02:23:56]

Given the return value, how about DetermineLoggingDestination?

[achuithb, 2017/05/25 10:06:06]

Done.

+
 #if defined(OS_CHROMEOS)

[xiyuan, 2017/05/24 15:15:33]

Move everything in this section to the new chrome/logging.h|cc ?

[achuithb, 2017/05/24 21:07:55]

These are all used by the platform-independent InitChromeLogging :/

[xiyuan, 2017/05/24 21:16:19]

Okay. :(

+// Point the logging symlink to the system log or the user session log.
+base::FilePath SetUpSymlinkIfNeeded(const base::FilePath& symlink_path,
+                                    bool new_log);
+
+// Remove the logging symlink.
+void RemoveSymlinkAndLog(const base::FilePath& link_path,
+                         const base::FilePath& target_path);
+
 // Get the log file directory path.
 base::FilePath GetSessionLogDir(const base::CommandLine& command_line);
 
 // Get the log file location.
 base::FilePath GetSessionLogFile(const base::CommandLine& command_line);
-
-// Redirects chrome logging to the appropriate session log dir.
-void RedirectChromeLogging(const base::CommandLine& command_line);
 #endif
 
 // Call when done using logging for Chrome.
 void CleanupChromeLogging();
 
 // Returns the fully-qualified name of the log file.
 base::FilePath GetLogFileName();
 
 // Returns true when error/assertion dialogs are not to be shown, false
 // otherwise.
 bool DialogsAreSuppressed();
 
 // Inserts timestamp before file extension in the format
 // "_yymmdd-hhmmss".
 base::FilePath GenerateTimestampedName(const base::FilePath& base_path,
                                        base::Time timestamp);
 }  // namespace logging
 
 #endif  // CHROME_COMMON_LOGGING_CHROME_H_