Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: build/toolchain/win/BUILD.gn

Issue 2901163002: Use assembly instead of C array literals to link the core snapshot into the VM. (Closed)
Patch Set: windows Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/bin/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Path to the directory containing the VC binaries for the right 6 # Path to the directory containing the VC binaries for the right
7 # combination of host and target architectures. Currently only the 7 # combination of host and target architectures. Currently only the
8 # 64-bit host toolchain is supported, with either 32-bit or 64-bit targets. 8 # 64-bit host toolchain is supported, with either 32-bit or 64-bit targets.
9 # If vc_bin_dir is not specified on the command line (and it normally 9 # If vc_bin_dir is not specified on the command line (and it normally
10 # isn't), we will dynamically determine the right value to use at runtime. 10 # isn't), we will dynamically determine the right value to use at runtime.
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 105
106 tool("rc") { 106 tool("rc") {
107 command = "$python_path gyp-win-tool rc-wrapper $env rc.exe {{defines}} {{ include_dirs}} /fo{{output}} {{source}}" 107 command = "$python_path gyp-win-tool rc-wrapper $env rc.exe {{defines}} {{ include_dirs}} /fo{{output}} {{source}}"
108 outputs = [ 108 outputs = [
109 "{{target_out_dir}}/{{target_output_name}}/{{source_name_part}}.res", 109 "{{target_out_dir}}/{{target_output_name}}/{{source_name_part}}.res",
110 ] 110 ]
111 description = "RC {{output}}" 111 description = "RC {{output}}"
112 } 112 }
113 113
114 tool("asm") { 114 tool("asm") {
115 # TODO(brettw): "/safeseh" assembler argument is hardcoded here. Extract 115 if (invoker.current_cpu == "x64") {
116 # assembler flags to a variable like cflags. crbug.com/418613 116 ml = "ml64.exe"
117 command = "$python_path gyp-win-tool asm-wrapper $env ml.exe {{defines}} { {include_dirs}} {{asmflags}} /safeseh /c /Fo {{output}} {{source}}" 117 x64 = "-D_ML64_X64"
118 } else {
119 ml = "ml.exe"
120 x64 = ""
121 }
122 command = "$python_path gyp-win-tool asm-wrapper $env $ml $x64 {{defines}} {{include_dirs}} {{asmflags}} /c /Fo {{output}} {{source}}"
118 description = "ASM {{output}}" 123 description = "ASM {{output}}"
119 outputs = [ 124 outputs = [
120 "{{target_out_dir}}/{{target_output_name}}/{{source_name_part}}.obj", 125 "{{target_out_dir}}/{{target_output_name}}/{{source_name_part}}.obj",
121 ] 126 ]
122 } 127 }
123 128
124 tool("alink") { 129 tool("alink") {
125 rspfile = "{{output}}.rsp" 130 rspfile = "{{output}}.rsp"
126 command = "$python_path gyp-win-tool link-wrapper $env False lib.exe /nolo go /ignore:4221 /OUT:{{output}} @$rspfile" 131 command = "$python_path gyp-win-tool link-wrapper $env False lib.exe /nolo go /ignore:4221 /OUT:{{output}} @$rspfile"
127 description = "LIB {{output}}" 132 description = "LIB {{output}}"
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 } 245 }
241 msvc_toolchain("clang_x64") { 246 msvc_toolchain("clang_x64") {
242 environment = "environment.x64" 247 environment = "environment.x64"
243 current_cpu = "x64" 248 current_cpu = "x64"
244 prefix = rebase_path("//third_party/llvm-build/Release+Asserts/bin", 249 prefix = rebase_path("//third_party/llvm-build/Release+Asserts/bin",
245 root_build_dir) 250 root_build_dir)
246 cl = "${goma_prefix}$prefix/clang-cl.exe" 251 cl = "${goma_prefix}$prefix/clang-cl.exe"
247 is_clang = true 252 is_clang = true
248 } 253 }
249 } 254 }
OLDNEW
« no previous file with comments | « no previous file | runtime/bin/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698