mojo/public/tools/bindings/pylib/mojom/parse/lexer.py - Issue 290113004: Mojo: Mojom: Don't allow $ in identifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/pylib/mojom/parse/lexer.py

Issue 290113004: Mojo: Mojom: Don't allow $ in identifiers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove redundant test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/pylib/mojom/parse/lexer.py

diff --git a/mojo/public/tools/bindings/pylib/mojom/parse/lexer.py b/mojo/public/tools/bindings/pylib/mojom/parse/lexer.py

index beceabcce7771f40ab0a8169cea9a1f2352e9fa8..18d1b13c8c96819157fbc2c4267921b2f895e612 100644

--- a/mojo/public/tools/bindings/pylib/mojom/parse/lexer.py

+++ b/mojo/public/tools/bindings/pylib/mojom/parse/lexer.py

@@ -113,8 +113,8 @@ class Lexer(object):

## Regexes for use in tokens

- # valid C identifiers (K&R2: A.2.3), plus '$' (supported by some compilers)

- identifier = r'[a-zA-Z_$][0-9a-zA-Z_$]*'

+ # valid C identifiers (K&R2: A.2.3)

+ identifier = r'[a-zA-Z_][0-9a-zA-Z_]*'

hex_prefix = '0[xX]'

hex_digits = '[0-9a-fA-F]+'

« no previous file with comments | « no previous file | mojo/public/tools/bindings/pylib/mojom_tests/parse/lexer_unittest.py » ('j') | no next file with comments »