Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9946)

Unified Diff: chrome/test/perf/mach_ports_performancetest.cc

Issue 2901113003: Fix breakages while performance_browser_tests was not running on Mac. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/BUILD.gn ('k') | media/cast/test/utility/standalone_cast_environment.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/perf/mach_ports_performancetest.cc
diff --git a/chrome/test/perf/mach_ports_performancetest.cc b/chrome/test/perf/mach_ports_performancetest.cc
index 7887298a76fbd5160b8af5f583b70e529ce0b824..e7b1d786fd4a0bf15f69af0a17a80cf550a5ae64 100644
--- a/chrome/test/perf/mach_ports_performancetest.cc
+++ b/chrome/test/perf/mach_ports_performancetest.cc
@@ -25,13 +25,13 @@ namespace {
class MachPortsTest : public InProcessBrowserTest {
public:
MachPortsTest() {
- server_.ServeFilesFromSourceDirectory("data/mach_ports/moz");
+ embedded_test_server()->ServeFilesFromSourceDirectory(
+ "data/mach_ports/moz");
}
- void SetUp() override {
- InProcessBrowserTest::SetUp();
-
- ASSERT_TRUE(server_.Start());
+ void SetUpOnMainThread() override {
+ InProcessBrowserTest::SetUpOnMainThread();
+ ASSERT_TRUE(embedded_test_server()->Start());
}
void TearDown() override {
@@ -72,12 +72,12 @@ class MachPortsTest : public InProcessBrowserTest {
// Adds a tab from the page cycler data at the specified domain.
void AddTab(const std::string& domain) {
- GURL url = server_.GetURL("/" + domain + "/").Resolve("?skip");
- AddTabAtIndex(0, url, ui::PAGE_TRANSITION_TYPED);
+ AddTabAtIndex(
+ 0, embedded_test_server()->GetURL("/" + domain + "/").Resolve("?skip"),
+ ui::PAGE_TRANSITION_TYPED);
}
private:
- net::EmbeddedTestServer server_;
std::vector<int> port_counts_;
};
« no previous file with comments | « chrome/test/BUILD.gn ('k') | media/cast/test/utility/standalone_cast_environment.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698