[USS] Implement GetAllData and GetStorageKey.

components/history/core/browser/typed_url_sync_metadata_database_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/history/core/browser/typed_url_sync_metadata_database.h"
 
+#include "base/big_endian.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
+#include "components/history/core/browser/url_row.h"
 #include "components/sync/protocol/model_type_state.pb.h"
 #include "sql/statement.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using sync_pb::EntityMetadata;
 using sync_pb::ModelTypeState;
 using syncer::EntityMetadataMap;
 using syncer::MetadataBatch;
 
 namespace history {
 
+namespace {
+
+std::string IntToStorageKey(int i) {
+  std::string storage_key(8, 0);
+  base::WriteBigEndian(&storage_key[0], static_cast<URLID>(i));

[pavely, 2017/06/01 20:49:18]

nit: I think you can explicitly specify which variant of WriteBigEndian to use
by providing template parameter:
base::WriteBigEndian<URLID>(storage_key.data(), i);

[Gang Wu, 2017/06/02 00:00:24]

Done.

+  return storage_key;
+}
+
+}  // namespace
+
 class TypedURLSyncMetadataDatabaseTest : public testing::Test,
                                          public TypedURLSyncMetadataDatabase {
  public:
   TypedURLSyncMetadataDatabaseTest() {}
   ~TypedURLSyncMetadataDatabaseTest() override {}
 
  protected:
   sql::Connection& GetDB() override { return db_; }
 
   void SetUp() override {
@@ skipping 23 matching lines @@
 TEST_F(TypedURLSyncMetadataDatabaseTest, TypedURLNoMetadata) {
   MetadataBatch metadata_batch;
   EXPECT_TRUE(GetAllSyncMetadata(&metadata_batch));
   EXPECT_EQ(0u, metadata_batch.TakeAllMetadata().size());
   EXPECT_EQ(ModelTypeState().SerializeAsString(),
             metadata_batch.GetModelTypeState().SerializeAsString());
 }
 
 TEST_F(TypedURLSyncMetadataDatabaseTest, TypedURLGetAllSyncMetadata) {
   EntityMetadata metadata;
-  std::string storage_key = "1";
-  std::string storage_key2 = "2";
+  std::string storage_key = IntToStorageKey(0);
+  std::string storage_key2 = IntToStorageKey(1);
   metadata.set_sequence_number(1);
 
   EXPECT_TRUE(UpdateSyncMetadata(syncer::TYPED_URLS, storage_key, metadata));
 
   ModelTypeState model_type_state;
   model_type_state.set_initial_sync_done(true);
 
   EXPECT_TRUE(UpdateModelTypeState(syncer::TYPED_URLS, model_type_state));
 
   metadata.set_sequence_number(2);
@@ skipping 14 matching lines @@
   model_type_state.set_initial_sync_done(false);
   EXPECT_TRUE(UpdateModelTypeState(syncer::TYPED_URLS, model_type_state));
 
   EXPECT_TRUE(GetAllSyncMetadata(&metadata_batch));
   EXPECT_FALSE(metadata_batch.GetModelTypeState().initial_sync_done());
 }
 
 TEST_F(TypedURLSyncMetadataDatabaseTest, TypedURLWriteThenDeleteSyncMetadata) {
   EntityMetadata metadata;
   MetadataBatch metadata_batch;
-  std::string storage_key = "1";
+  std::string storage_key = IntToStorageKey(1);
   ModelTypeState model_type_state;
 
   model_type_state.set_initial_sync_done(true);
 
   metadata.set_client_tag_hash("client_hash");
 
   // Write the data into the store.
   EXPECT_TRUE(UpdateSyncMetadata(syncer::TYPED_URLS, storage_key, metadata));
   EXPECT_TRUE(UpdateModelTypeState(syncer::TYPED_URLS, model_type_state));
   // Delete the data we just wrote.
@@ skipping 24 matching lines @@
 }
 
 TEST_F(TypedURLSyncMetadataDatabaseTest, TypedURLCorruptModelTypeState) {
   MetadataBatch metadata_batch;
   GetMetaTable().SetValue("typed_url_model_type_state", "unparseable");
 
   EXPECT_FALSE(GetAllSyncMetadata(&metadata_batch));
 }
 
 }  // namespace history