Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: net/http/http_server_properties_manager.cc

Issue 2901093004: Add and persist a new field in AlternativeServiceInfo to list QUIC verisons advertised (Closed)
Patch Set: self review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_server_properties_manager.cc
diff --git a/net/http/http_server_properties_manager.cc b/net/http/http_server_properties_manager.cc
index 2af299fafc361153336c1ea1ad302157bf418f6c..ecd733fa5af6706a13173178a335f56ecd33aad9 100644
--- a/net/http/http_server_properties_manager.cc
+++ b/net/http/http_server_properties_manager.cc
@@ -201,10 +201,11 @@ HttpServerPropertiesManager::GetAlternativeServiceInfos(
bool HttpServerPropertiesManager::SetAlternativeService(
const url::SchemeHostPort& origin,
const AlternativeService& alternative_service,
- base::Time expiration) {
+ base::Time expiration,
+ const QuicVersionVector& advertised_versions) {
DCHECK(network_task_runner_->RunsTasksOnCurrentThread());
const bool changed = http_server_properties_impl_->SetAlternativeService(
- origin, alternative_service, expiration);
+ origin, alternative_service, expiration, advertised_versions);
if (changed) {
ScheduleUpdatePrefsOnNetworkThread(SET_ALTERNATIVE_SERVICES);
}
@@ -629,6 +630,9 @@ bool HttpServerPropertiesManager::ParseAlternativeServiceDict(
return true;
}
+ // TODO(zhongyi): add support for reading advertised versions to
+ // AlternativeServiceInfo.
+
DVLOG(1) << "Malformed alternative service expiration for server: "
<< server_str;
return false;

Powered by Google App Engine
This is Rietveld 408576698