build/android/pylib/instrumentation/instrumentation_test_instance.py - Issue 2901053003: 📷 Create RenderTestRule which fails after test method finishes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 2901053003: 📷 Create RenderTestRule which fails after test method finishes. (Closed)

Patch Set: Typo in comment. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/instrumentation/instrumentation_test_instance.py

diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py

index 071e73ca5febabdc4ee08fad46ca72f681a043c6..6f31a33008538c3add76dfc29129a79251cfa10c 100644

--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py

+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py

@@ -653,8 +653,6 @@ class InstrumentationTestInstance(test_instance.TestInstance):

self._flags.extend(flag for flag in stripped_lines if flag)

if args.strict_mode and args.strict_mode != 'off':

self._flags.append('--strict-mode=' + args.strict_mode)

- if args.regenerate_goldens:

- self._flags.append('--regenerate-goldens')

def _initializeDriverAttributes(self):

self._driver_apk = os.path.join(

« no previous file with comments | « no previous file | build/android/pylib/instrumentation/instrumentation_test_instance_test.py » ('j') | no next file with comments »