Host port range policy is no longer ignored in it2me host

remoting/host/it2me/it2me_host.h

Index: remoting/host/it2me/it2me_host.h
diff --git a/remoting/host/it2me/it2me_host.h b/remoting/host/it2me/it2me_host.h
index 18df48cdcf3c9a93f354495ecf945f81f6626312..2815d1df57faf8c9375b29d79ccd41a10da371b4 100644
--- a/remoting/host/it2me/it2me_host.h
+++ b/remoting/host/it2me/it2me_host.h
@@ -9,12 +9,14 @@
 #include <string>
 #include <vector>
 
+#include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "remoting/host/host_status_observer.h"
 #include "remoting/host/it2me/it2me_confirmation_dialog.h"
 #include "remoting/host/it2me/it2me_confirmation_dialog_proxy.h"
+#include "remoting/protocol/port_range.h"
 #include "remoting/protocol/validating_authenticator.h"
 #include "remoting/signaling/xmpp_signal_strategy.h"
 
@@ -105,6 +107,15 @@ class It2MeHost : public base::RefCountedThreadSafe<It2MeHost>,
   base::WeakPtr<It2MeHost::Observer> observer() { return observer_; }
 
  private:
+  FRIEND_TEST_ALL_PREFIXES(
+      It2MeHostTest,
+      ConnectionValidation_HostUdpPortRangePolicy_ValidRange);
+  FRIEND_TEST_ALL_PREFIXES(
+      It2MeHostTest,
+      ConnectionValidation_HostUdpPortRangePolicy_InvalidRange);
+  FRIEND_TEST_ALL_PREFIXES(It2MeHostTest,
+                           ConnectionValidation_HostUdpPortRangePolicy_NoRange);
+
   // Updates state of the host. Can be called only on the network thread.
   void SetState(It2MeHostState state, const std::string& error_message);
 
@@ -132,6 +143,7 @@ class It2MeHost : public base::RefCountedThreadSafe<It2MeHost>,
   void UpdateHostDomainListPolicy(std::vector<std::string> host_domain_list);
   void UpdateClientDomainListPolicy(
       std::vector<std::string> client_domain_list);
+  void UpdateHostUdpPortRangePolicy(std::string port_range_string);

[Sergey Ulanov, 2017/05/25 19:34:53]

use const reference to pass strings (const std::string&)

[Gus Smith, 2017/05/25 21:39:09]

Done.

 
   void DisconnectOnNetworkThread();
 
@@ -169,6 +181,9 @@ class It2MeHost : public base::RefCountedThreadSafe<It2MeHost>,
   std::vector<std::string> required_client_domain_list_;
   std::vector<std::string> required_host_domain_list_;
 
+  // The host port range policy setting.
+  std::string udp_port_range_string_;

[Sergey Ulanov, 2017/05/25 19:34:53]

It's better to store parsed PortRange value.

[Gus Smith, 2017/05/25 21:39:09]

Done.

+
   // Tracks the JID of the remote user when in a connecting state.
   std::string connecting_jid_;