Host port range policy is no longer ignored in it2me host

remoting/host/it2me/it2me_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/it2me/it2me_host.h"
 
 #include <cstdint>
 #include <memory>
 #include <string>
 #include <utility>
@@ skipping 312 matching lines @@
   const base::ListValue* client_domain_list;
   if (policies->GetList(policy::key::kRemoteAccessHostClientDomainList,
                         &client_domain_list)) {
     std::vector<std::string> client_domain_list_vector;
     for (const auto& value : *client_domain_list) {
       client_domain_list_vector.push_back(value.GetString());
     }
     UpdateClientDomainListPolicy(std::move(client_domain_list_vector));
   }
 
+  // TODO(gusss) don't ignore port range
+  std::string port_range_string;
+  if (policies->GetString(policy::key::kRemoteAccessHostUdpPortRange,
+                          &port_range_string)) {
+    UpdateHostUdpPortRangePolicy(port_range_string);
+  }
+
   policy_received_ = true;
 
   if (!pending_connect_.is_null()) {
     base::ResetAndReturn(&pending_connect_).Run();
   }
 }
 
 void It2MeHost::UpdateNatPolicy(bool nat_traversal_enabled) {
   DCHECK(host_context_->network_task_runner()->BelongsToCurrentThread());
 
@@ skipping 36 matching lines @@
           << base::JoinString(client_domain_list, ", ");
 
   // When setting a client  domain policy, disconnect any existing session.
   if (!client_domain_list.empty() && IsRunning()) {
     DisconnectOnNetworkThread();
   }
 
   required_client_domain_list_ = std::move(client_domain_list);
 }
 
+void It2MeHost::UpdateHostUdpPortRangePolicy(std::string port_range_string) {
+  // TODO(gusss) i copied this; need to figure out what it actually does!

[Sergey Ulanov, 2017/05/23 20:11:01]

It verifies that this function is called on the right thread.

+  DCHECK(host_context_->network_task_runner()->BelongsToCurrentThread());
+
+  VLOG(2) << "UpdateHostUdpPortRangePolicy: " << port_range_string;
+
+  if (!PortRange::Parse(port_range_string, &udp_port_range_)) {
+    // TODO(gusss) how to handle formatting error in this case?

[Sergey Ulanov, 2017/05/23 20:11:01]

I think we need to stop the host in this case. I think something like this
should work:
  SetState(kError, "Invalid RemoteAccessHostUdpPortRange policy value.");
  DisconnectOnNetworkThread();

+  }
+
+  // TODO(gusss) do we have to disconnect?

[Sergey Ulanov, 2017/05/23 20:11:01]

Yes, same as in UpdateClientDomainListPolicy()

+}
+
 void It2MeHost::SetState(It2MeHostState state,
                          const std::string& error_message) {
   DCHECK(host_context_->network_task_runner()->BelongsToCurrentThread());
 
   switch (state_) {
     case kDisconnected:
       DCHECK(state == kStarting ||
              state == kError) << state;
       break;
     case kStarting:
@@ skipping 177 matching lines @@
     std::unique_ptr<SignalStrategy> signal_strategy,
     const std::string& username,
     const std::string& directory_bot_jid) {
   DCHECK(context->ui_task_runner()->BelongsToCurrentThread());
   return new It2MeHost(
       std::move(context), base::MakeUnique<It2MeConfirmationDialogFactory>(),
       observer, std::move(signal_strategy), username, directory_bot_jid);
 }
 
 }  // namespace remoting