Disable learning text suggestions if in incognito.

chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.omnibox;
 
 import android.content.ClipData;
 import android.content.ClipboardManager;
 import android.content.Context;
 import android.content.res.Resources;
 import android.graphics.Canvas;
 import android.graphics.Paint;
 import android.graphics.Rect;
 import android.net.Uri;
 import android.os.Build;
 import android.os.StrictMode;
 import android.os.SystemClock;
 import android.text.Editable;
 import android.text.Layout;
 import android.text.Selection;
 import android.text.TextUtils;
 import android.text.style.ReplacementSpan;
 import android.util.AttributeSet;
 import android.util.Pair;
 import android.view.GestureDetector;
 import android.view.KeyEvent;
 import android.view.MotionEvent;
 import android.view.View;
 import android.view.accessibility.AccessibilityNodeInfo;
+import android.view.inputmethod.EditorInfo;
+import android.view.inputmethod.InputConnection;
 import android.widget.TextView;
 
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.base.Log;
 import org.chromium.base.SysUtils;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.WindowDelegate;
 import org.chromium.chrome.browser.metrics.StartupMetrics;
 import org.chromium.chrome.browser.omnibox.LocationBarLayout.OmniboxLivenessListener;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.browser.util.UrlUtilities;
 import org.chromium.content.browser.ContentViewCore;
 import org.chromium.ui.UiUtils;
 
 import java.net.MalformedURLException;
 import java.net.URI;
 import java.net.URISyntaxException;
 import java.net.URL;
 
 /**
  * The URL text entry view for the Omnibox.
  */
 public class UrlBar extends AutocompleteEditText {
     private static final String TAG = "cr_UrlBar";
 
     private static final boolean DEBUG = false;
 
+    // TODO(tedchoc): Replace with EditorInfoCompat#IME_FLAG_NO_PERSONALIZED_LEARNING or
+    //                EditorInfo#IME_FLAG_NO_PERSONALIZED_LEARNING as soon as either is available in
+    //                all build config types.
+    private static final int IME_FLAG_NO_PERSONALIZED_LEARNING = 0x1000000;
+
     // TextView becomes very slow on long strings, so we limit maximum length
     // of what is displayed to the user, see limitDisplayableLength().
     private static final int MAX_DISPLAYABLE_LENGTH = 4000;
     private static final int MAX_DISPLAYABLE_LENGTH_LOW_END = 1000;
 
     // Unicode "Left-To-Right Mark" (LRM) character.
     private static final char LRM = '\u200E';
 
     /** The contents of the URL that precede the path/query after being formatted. */
     private String mFormattedUrlLocation;
@@ skipping 66 matching lines @@
     /**
      * Delegate used to communicate with the content side and the parent layout.
      */
     public interface UrlBarDelegate {
         /**
          * @return The current active {@link Tab}.
          */
         Tab getCurrentTab();
 
         /**
+         * @return Whether the user has entered incognito mode.
+         */
+        boolean isIncognito();
+
+        /**
          * Called when the text state has changed and the autocomplete suggestions should be
          * refreshed.
          *
          * @param textDeleted Whether this change was as a result of text being deleted.
          */
         void onTextChangedForAutocomplete(boolean textDeleted);
 
         /**
          * @return Whether the light security theme should be used.
          */
@@ skipping 479 matching lines @@
         // outside the RTL-extent that contains the domain. crbug.com/723100
         if (urlComponents.first.length() > 1) {
             bringPointIntoView(1);
         }
         bringPointIntoView(urlComponents.first.length());
 
         return true;
     }
 
     @Override
+    public InputConnection onCreateInputConnection(EditorInfo outAttrs) {
+        InputConnection connection = super.onCreateInputConnection(outAttrs);
+        if (mUrlBarDelegate != null && mUrlBarDelegate.isIncognito()) {

[Changwan Ryu, 2017/05/23 18:54:23]

This should arguably be

assert mUrlBarDelegate != null;
if (mUrlBarDelegate.isIncognito()) {

to ensure the flag option without having to manually check all the call sites of
setDelegate(), but it's a bit scary because we need to depend on unspecified
android framework behavior..

Maybe we could have both assert and null check if we want to avoid crash while
keeping track of flag issue.. WDYT?

[Ted C, 2017/05/23 19:17:55]

I think the null and assert seems safest.  I would hope no android version
would call this as part of the constructor, but I have also no confidence
that some version doesn't do just that.

+            outAttrs.imeOptions |= IME_FLAG_NO_PERSONALIZED_LEARNING;
+        }
+        return connection;
+    }
+
+    @Override
     protected void onTextChanged(CharSequence text, int start, int lengthBefore, int lengthAfter) {
         super.onTextChanged(text, start, lengthBefore, lengthAfter);
         mIsPastedText = false;
     }
 
     @Override
     public void setText(CharSequence text, BufferType type) {
         if (DEBUG) Log.i(TAG, "setText -- text: %s", text);
         super.setText(text, type);
         fixupTextDirection();
@@ skipping 148 matching lines @@
             return (int) paint.measureText(ELLIPSIS);
         }
 
         @Override
         public void draw(Canvas canvas, CharSequence text, int start, int end,
                 float x, int top, int y, int bottom, Paint paint) {
             canvas.drawText(ELLIPSIS, x, y, paint);
         }
     }
 }