Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: content/browser/accessibility/browser_accessibility_android.cc

Issue 2901003002: Special case for Android list items no longer needed to remove name, because list items are no longe (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/browser_accessibility_android.cc
diff --git a/content/browser/accessibility/browser_accessibility_android.cc b/content/browser/accessibility/browser_accessibility_android.cc
index fd0bab70144f0a8f95c61b7533cc33c9d88387a2..a605e2aa7e8cac1dfa4c6215de7da3a1259aeb79 100644
--- a/content/browser/accessibility/browser_accessibility_android.cc
+++ b/content/browser/accessibility/browser_accessibility_android.cc
@@ -344,18 +344,6 @@ base::string16 BrowserAccessibilityAndroid::GetText() const {
return base::string16();
}
- // In accordance with ARIA, some elements use their contents as an
- // accessibility name, so some elements will have the same name as their
- // child. While most platforms expect this, it causes Android to speak the
- // name twice. So in this case we should remove the name from the parent.
- if (GetRole() == ui::AX_ROLE_LIST_ITEM &&
- GetIntAttribute(ui::AX_ATTR_NAME_FROM) == ui::AX_NAME_FROM_CONTENTS) {
- // This is an approximation of "PlatformChildCount() > 0" because we can't
- // call PlatformChildCount from here.
- if (InternalChildCount() > 0 && !HasOnlyTextChildren())
- return base::string16();
- }
-
// We can only expose one accessible name on Android,
// not 2 or 3 like on Windows or Mac.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698