Mark a test flaky.

Mark two tests flaky.

They triy to use a timeout to reduce flakiness, but that only
makes them fail less often; they are still not completely reliable.

BUG=48562
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51867

[cbentzel, 2010-07-08 18:17:17]

LGTM

Thanks, Evan.

Should you add bug 38093 to the list as well?

On Thu, Jul 8, 2010 at 2:13 PM, <evan@chromium.org> wrote:

> Reviewers: Paweł Hajdan Jr., Erik Kay,
>
> Description:
> Mark two tests flaky.
>
> They triy to use a timeout to reduce flakiness, but that only
> makes them fail less often; they are still not completely reliable.
>
> BUG=48562
>
> Please review this at http://codereview.chromium.org/2901003/show
>
> Affected files:
>  M chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc
>  M net/base/listen_socket_unittest.cc
>
>
> Index: chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc
> diff --git
> a/chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc
> b/chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc
> index
>
79933fe3c1076bdb3812aa853f1d871f9e55c667..891a19b9935d43373bd60adde036aab6ffc6d3dc
> 100644
> --- a/chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc
> +++ b/chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc
> @@ -343,7 +343,8 @@ class DevToolsRemoteListenSocketTest: public
> PlatformTest {
>   scoped_refptr<DevToolsRemoteListenSocketTester> tester_;
>  };
>
> -TEST_F(DevToolsRemoteListenSocketTest, ServerSend) {
> +// This test is flaky; see comment in ::TestServerSend.
> +TEST_F(DevToolsRemoteListenSocketTest, FLAKY_ServerSend) {
>   tester_->TestServerSend();
>  }
>
> Index: net/base/listen_socket_unittest.cc
> diff --git a/net/base/listen_socket_unittest.cc
> b/net/base/listen_socket_unittest.cc
> index
>
f33ac3c8ae4f0be280aeae3b240e0b497bc62396..99e0250c37652a8aebf136cdfa18b9c4dc4b84da
> 100644
> --- a/net/base/listen_socket_unittest.cc
> +++ b/net/base/listen_socket_unittest.cc
> @@ -319,6 +319,7 @@ TEST_F(ListenSocketTest, ClientSendLong) {
>   tester_->TestClientSendLong();
>  }
>
> -TEST_F(ListenSocketTest, ServerSend) {
> +// This test is flaky; see comment in ::TestServerSend.
> +TEST_F(ListenSocketTest, FLAKY_ServerSend) {
>   tester_->TestServerSend();
>  }
>
>
>

[Paweł Hajdan Jr., 2010-07-08 18:17:47]

http://codereview.chromium.org/2901003/diff/2001/3001
File chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc (right):

http://codereview.chromium.org/2901003/diff/2001/3001#newcode346
chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc:346: // This
test is flaky; see comment in ::TestServerSend.
Could you file a bug for this and put the link in the comment?

http://codereview.chromium.org/2901003/diff/2001/3002
File net/base/listen_socket_unittest.cc (right):

http://codereview.chromium.org/2901003/diff/2001/3002#newcode322
net/base/listen_socket_unittest.cc:322: // This test is flaky; see comment in
::TestServerSend.
Same here.

[Evan Martin, 2010-07-08 18:25:05]

ok, committing with bug link in comment