Ignore form action URL when determine if a credential should be autofilled.

chrome/browser/password_manager/password_manager_test_base.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_manager_test_base.h"
 
 #include <string>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
@@ skipping 47 matching lines @@
 // ManagePasswordsUIController subclass to capture the UI events.
 class CustomManagePasswordsUIController : public ManagePasswordsUIController {
  public:
   explicit CustomManagePasswordsUIController(
       content::WebContents* web_contents);
 
   void WaitForState(password_manager::ui::State target_state);
 
  private:
   // PasswordsClientUIDelegate:
+  void OnPasswordSubmitted(

[dvadym, 2017/05/23 14:59:52]

Why do we need this, it looks that this method is not used in tests now?

[vasilii, 2017/05/24 12:48:36]

It's how WaitForSavePrompt() is implemented. This method is called when the
bubble is to be popped up. Thus, it's time to quit the RunLoop.

+      std::unique_ptr<password_manager::PasswordFormManager> form_manager)
+      override;
   bool OnChooseCredentials(
       std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials,
       const GURL& origin,
       const ManagePasswordsState::CredentialsCallback& callback) override;
   void OnPasswordAutofilled(
       const std::map<base::string16, const autofill::PasswordForm*>&
           password_form_map,
       const GURL& origin,
       const std::vector<const autofill::PasswordForm*>* federated_matches)
       override;
@@ skipping 21 matching lines @@
 }
 
 void CustomManagePasswordsUIController::WaitForState(
     password_manager::ui::State target_state) {
   base::RunLoop run_loop;
   target_state_ = target_state;
   run_loop_ = &run_loop;
   run_loop_->Run();
 }
 
+void CustomManagePasswordsUIController::OnPasswordSubmitted(
+    std::unique_ptr<password_manager::PasswordFormManager> form_manager) {
+  if (target_state_ == password_manager::ui::PENDING_PASSWORD_STATE) {
+    run_loop_->Quit();
+    run_loop_ = nullptr;
+    target_state_ = password_manager::ui::INACTIVE_STATE;
+  }
+  return ManagePasswordsUIController::OnPasswordSubmitted(
+      std::move(form_manager));
+}
+
 bool CustomManagePasswordsUIController::OnChooseCredentials(
     std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials,
     const GURL& origin,
     const ManagePasswordsState::CredentialsCallback& callback) {
   if (target_state_ == password_manager::ui::CREDENTIAL_REQUEST_STATE) {
     run_loop_->Quit();
     run_loop_ = nullptr;
     target_state_ = password_manager::ui::INACTIVE_STATE;
   }
   return ManagePasswordsUIController::OnChooseCredentials(
@@ skipping 108 matching lines @@
 
 void BubbleObserver::WaitForManagementState() const {
   if (passwords_ui_controller_->GetState() ==
       password_manager::ui::MANAGE_STATE)
     return;
   CustomManagePasswordsUIController* controller =
       static_cast<CustomManagePasswordsUIController*>(passwords_ui_controller_);
   controller->WaitForState(password_manager::ui::MANAGE_STATE);
 }
 
+void BubbleObserver::WaitForSavePrompt() const {
+  if (passwords_ui_controller_->GetState() ==
+      password_manager::ui::PENDING_PASSWORD_STATE)
+    return;
+  CustomManagePasswordsUIController* controller =
+      static_cast<CustomManagePasswordsUIController*>(passwords_ui_controller_);
+  controller->WaitForState(password_manager::ui::PENDING_PASSWORD_STATE);
+}
+
 PasswordManagerBrowserTestBase::PasswordManagerBrowserTestBase()
     : https_test_server_(net::EmbeddedTestServer::TYPE_HTTPS),
       web_contents_(nullptr) {}
 
 PasswordManagerBrowserTestBase::~PasswordManagerBrowserTestBase() = default;
 
 void PasswordManagerBrowserTestBase::SetUpOnMainThread() {
   // Use TestPasswordStore to remove a possible race. Normally the
   // PasswordStore does its database manipulation on the DB thread, which
   // creates a possible race during navigation. Specifically the
@@ skipping 218 matching lines @@
 
   content::BrowserThread::PostTaskAndReply(
       content::BrowserThread::IO, FROM_HERE,
       base::BindOnce(
           &AddHSTSHostImpl,
           make_scoped_refptr(browser()->profile()->GetRequestContext()), host),
       run_loop.QuitClosure());
 
   run_loop.Run();
 }