Issue 2900963009: enable analyzer scanner adapter generic method support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2900963009: enable analyzer scanner adapter generic method support (Closed)

Created:
3 years, 7 months ago by danrubel

Modified:
3 years, 7 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

enable analyzer scanner adapter generic method support This turns on generic method support in the scanner adapter layer and updates the token.offset when the analyzer scanner is being used to parse generic method comments. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/6e981d0cbf2fa0d41765bb78b10c2021f6939b6f

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -29 lines)			Patch
M	pkg/analyzer/lib/src/dart/scanner/scanner.dart	View	6 chunks	+27 lines, -10 lines	0 comments	Download
M	pkg/analyzer/lib/src/fasta/token_utils.dart	View	1 chunk	+10 lines, -2 lines	0 comments	Download
M	pkg/front_end/lib/src/scanner/reader.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/front_end/test/scanner_roundtrip_test.dart	View	1 chunk	+0 lines, -16 lines	0 comments	Download

Total messages: 5 (2 generated)

danrubel

3 years, 7 months ago (2017-05-24 17:37:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6e981d0cbf2fa0d41765bb78b10c2021f6939b6f (presubmit successful).