Reapply "Shuffle around deopt id allocation...

runtime/vm/simulator_dbc.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <setjmp.h>  // NOLINT
 #include <stdlib.h>
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_DBC)
 
@@ skipping 2937 matching lines @@
     SP[2] = SP[-1];  // Type arguments
     Exit(thread, FP, SP + 3, pc);
     NativeArguments args(thread, 2, SP + 1, SP - 1);
     INVOKE_RUNTIME(DRT_AllocateObject, args);
     SP -= 1;  // Result is in SP - 1.
     DISPATCH();
   }
 
   {
     BYTECODE(CreateArrayOpt, A_B_C);
-    const intptr_t length = Smi::Value(RAW_CAST(Smi, FP[rB]));
-    if (LIKELY(static_cast<uintptr_t>(length) <= Array::kMaxElements)) {
-      const intptr_t fixed_size_plus_alignment_padding =
-          sizeof(RawArray) + kObjectAlignment - 1;
-      const intptr_t instance_size =
-          (fixed_size_plus_alignment_padding + length * kWordSize) &
-          ~(kObjectAlignment - 1);
-      const uword start =
-          thread->heap()->new_space()->TryAllocate(instance_size);
-      if (LIKELY(start != 0)) {
-        const intptr_t cid = kArrayCid;
-        uword tags = 0;
-        if (LIKELY(instance_size <= RawObject::SizeTag::kMaxSizeTag)) {
-          tags = RawObject::SizeTag::update(instance_size, tags);
+    if (LIKELY(!FP[rB]->IsHeapObject())) {
+      const intptr_t length = Smi::Value(RAW_CAST(Smi, FP[rB]));
+      if (LIKELY(static_cast<uintptr_t>(length) <= Array::kMaxElements)) {
+        const intptr_t fixed_size_plus_alignment_padding =
+            sizeof(RawArray) + kObjectAlignment - 1;
+        const intptr_t instance_size =
+            (fixed_size_plus_alignment_padding + length * kWordSize) &
+            ~(kObjectAlignment - 1);
+        const uword start =
+            thread->heap()->new_space()->TryAllocate(instance_size);
+        if (LIKELY(start != 0)) {
+          const intptr_t cid = kArrayCid;
+          uword tags = 0;
+          if (LIKELY(instance_size <= RawObject::SizeTag::kMaxSizeTag)) {
+            tags = RawObject::SizeTag::update(instance_size, tags);
+          }
+          tags = RawObject::ClassIdTag::update(cid, tags);
+          *reinterpret_cast<uword*>(start + Instance::tags_offset()) = tags;
+          *reinterpret_cast<RawObject**>(start + Array::length_offset()) =
+              FP[rB];
+          *reinterpret_cast<RawObject**>(
+              start + Array::type_arguments_offset()) = FP[rC];
+          RawObject** data =
+              reinterpret_cast<RawObject**>(start + Array::data_offset());
+          for (intptr_t i = 0; i < length; i++) {
+            data[i] = null_value;
+          }
+          FP[rA] = reinterpret_cast<RawObject*>(start + kHeapObjectTag);
+          pc += 4;
         }
-        tags = RawObject::ClassIdTag::update(cid, tags);
-        *reinterpret_cast<uword*>(start + Instance::tags_offset()) = tags;
-        *reinterpret_cast<RawObject**>(start + Array::length_offset()) = FP[rB];
-        *reinterpret_cast<RawObject**>(start + Array::type_arguments_offset()) =
-            FP[rC];
-        RawObject** data =
-            reinterpret_cast<RawObject**>(start + Array::data_offset());
-        for (intptr_t i = 0; i < length; i++) {
-          data[i] = null_value;
-        }
-        FP[rA] = reinterpret_cast<RawObject*>(start + kHeapObjectTag);
-        pc += 4;
       }
     }
     DISPATCH();
   }
 
   {
     BYTECODE(CreateArrayTOS, 0);
     SP[1] = SP[-0];  // Length.
     SP[2] = SP[-1];  // Type.
     Exit(thread, FP, SP + 3, pc);
@@ skipping 902 matching lines @@
     pc_ = pc;
   }
 
   buf->Longjmp();
   UNREACHABLE();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_DBC