add UMA metrics for voice interaction entries.

chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h"
 
 #include <utility>
 #include <vector>
 
 #include "ash/accelerators/accelerator_controller.h"
 #include "ash/public/cpp/shell_window_ids.h"
 #include "ash/shell.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/containers/flat_set.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
+#include "base/metrics/user_metrics.h"
+#include "base/metrics/user_metrics_action.h"
 #include "base/task_scheduler/post_task.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chromeos/chromeos_switches.h"
 #include "components/arc/arc_bridge_service.h"
 #include "components/arc/instance_holder.h"
 #include "content/public/browser/browser_thread.h"
 #include "ui/aura/window.h"
 #include "ui/compositor/layer.h"
@@ skipping 87 matching lines @@
       base::Bind(
           [](const gfx::Image& image) -> std::vector<uint8_t> {
             std::vector<uint8_t> res;
             gfx::JPEG1xEncodedDataFromImage(image, 100, &res);
             return res;
           },
           image),
       callback);
 }
 
+void RecordShortcutAction(const ui::Accelerator& accelerator) {
+  if (accelerator.IsCmdDown() && accelerator.key_code() == ui::VKEY_A) {
+    if (accelerator.IsShiftDown()) {
+      base::RecordAction(base::UserMetricsAction(
+          "VoiceInteraction.MetaLayerEntry.Search_Shift_A"));

[Daniel Erat, 2017/05/24 13:07:55]

oh, i thought "meta" was referring to the meta key but i see now that there are
other references to a "meta layer" in this file.

it looks like it's capitalized as "Metalayer" (i.e. all one word) elsewhere. if
that's correct, please change this to match, i.e.
"VoiceInteraction.MetalayerEntry.Search_Shift_A".

[Muyuan, 2017/05/24 17:48:57]

Done.

+      return;
+    }
+    base::RecordAction(
+        base::UserMetricsAction("VoiceInteraction.Entry.Search_A"));
+    return;
+  }
+
+  if (accelerator.IsCmdDown() && accelerator.key_code() == ui::VKEY_SPACE) {
+    base::RecordAction(
+        base::UserMetricsAction("VoiceInteraction.Entry.Search_Space"));

[Daniel Erat, 2017/05/24 13:07:55]

return here to match the rest of the method and to avoid bugs if another case is
added below later

[Muyuan, 2017/05/24 17:48:57]

Done.

+  }
+}
+
 }  // namespace
 
 // static
 const char ArcVoiceInteractionFrameworkService::kArcServiceName[] =
     "arc::ArcVoiceInteractionFrameworkService";
 
 ArcVoiceInteractionFrameworkService::ArcVoiceInteractionFrameworkService(
     ArcBridgeService* bridge_service)
     : ArcService(bridge_service), binding_(this) {
   arc_bridge_service()->voice_interaction_framework()->AddObserver(this);
@@ skipping 29 matching lines @@
   ash::Shell::Get()->accelerator_controller()->UnregisterAll(this);
   if (!metalayer_closed_callback_.is_null())
     base::ResetAndReturn(&metalayer_closed_callback_).Run();
   metalayer_enabled_ = false;
 }
 
 bool ArcVoiceInteractionFrameworkService::AcceleratorPressed(
     const ui::Accelerator& accelerator) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
+  RecordShortcutAction(accelerator);
+
   if (accelerator.IsShiftDown()) {
     // Temporary, used for debugging.
     // Does not take into account or update the palette state.
     mojom::VoiceInteractionFrameworkInstance* framework_instance =
         ARC_GET_INSTANCE_FOR_METHOD(
             arc_bridge_service()->voice_interaction_framework(),
             SetMetalayerVisibility);
     DCHECK(framework_instance);
     framework_instance->SetMetalayerVisibility(true);
   } else {
@@ skipping 92 matching lines @@
           SetMetalayerVisibility);
   if (!framework_instance) {
     if (!metalayer_closed_callback_.is_null())
       base::ResetAndReturn(&metalayer_closed_callback_).Run();
     return;
   }
   framework_instance->SetMetalayerVisibility(visible);
 }
 
 }  // namespace arc