Issue 2900873002: Fix type inference of assignments to local variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2900873002: Fix type inference of assignments to local variables. (Closed)

Created:
3 years, 7 months ago by Paul Berry

Modified:
3 years, 7 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Fix type inference of assignments to local variables. If the variable's type was inferred, the inferred type should be used as the inference context for the RHS expression. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/79b4382784a55e0a562d8153ea957867725b878c

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -5 lines)			Patch
M	pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	pkg/front_end/test/fasta/strong.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
A	pkg/front_end/testcases/inference/block_bodied_lambdas_downwards_incompatible_with_upwards_inference.dart.strong.expect	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_sync.dart.strong.expect	View	1 chunk	+19 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

3 years, 7 months ago (2017-05-22 19:54:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
79b4382784a55e0a562d8153ea957867725b878c (presubmit successful).