DevTools: remove BreakpointsSidebarPaneBase and breakpointsList.css

third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @implements {UI.ContextFlavorListener}
  * @implements {UI.ToolbarItem.ItemsProvider}
  * @unrestricted
  */
-Sources.XHRBreakpointsSidebarPane = class extends Components.BreakpointsSidebarPaneBase {
+Sources.XHRBreakpointsSidebarPane = class extends UI.VBox {
   constructor() {
-    super();
+    super(true);
+    this.registerRequiredCSS('components/breakpointsList.css');
+
+    this._listElement = createElementWithClass('ol', 'breakpoint-list');

[dgozman, 2017/05/30 21:53:39]

ol -> div

[luoe, 2017/05/31 03:09:24]

Done.

+    this._emptyElement = this.contentElement.createChild('div', 'gray-info-message');
+    this._emptyElement.textContent = Common.UIString('No Breakpoints');
+
     /** @type {!Map.<string, !Element>} */
     this._breakpointElements = new Map();
 
     this._addButton = new UI.ToolbarButton(Common.UIString('Add breakpoint'), 'largeicon-add');
     this._addButton.addEventListener(UI.ToolbarButton.Events.Click, this._addButtonClicked.bind(this));
 
-    this.emptyElement.addEventListener('contextmenu', this._emptyElementContextMenu.bind(this), true);
+    this._emptyElement.addEventListener('contextmenu', this._emptyElementContextMenu.bind(this), true);
     this._restoreBreakpoints();
     this._update();
   }
 
   /**
    * @override
    * @return {!Array<!UI.ToolbarItem>}
    */
   toolbarItems() {
     return [this._addButton];
   }
 
   _emptyElementContextMenu(event) {
     var contextMenu = new UI.ContextMenu(event);
     contextMenu.appendItem(Common.UIString.capitalize('Add ^breakpoint'), this._addButtonClicked.bind(this));
     contextMenu.show();
   }
 
   _addButtonClicked() {
     UI.viewManager.showView('sources.xhrBreakpoints');
 
     var inputElementContainer = createElementWithClass('p', 'breakpoint-condition');
     inputElementContainer.textContent = Common.UIString('Break when URL contains:');
 
     var inputElement = inputElementContainer.createChild('span');
     inputElement.id = 'breakpoint-condition-input';
-    this.addListElement(inputElementContainer, /** @type {?Element} */ (this.listElement.firstChild));
+    this._addListElement(inputElementContainer, /** @type {?Element} */ (this._listElement.firstChild));
 
     /**
      * @param {boolean} accept
      * @param {!Element} e
      * @param {string} text
      * @this {Sources.XHRBreakpointsSidebarPane}
      */
     function finishEditing(accept, e, text) {
-      this.removeListElement(inputElementContainer);
+      this._removeListElement(inputElementContainer);
       if (accept) {
         SDK.domDebuggerManager.addXHRBreakpoint(text, true);
         this._setBreakpoint(text, true);
       }
     }
 
     var config = new UI.InplaceEditor.Config(finishEditing.bind(this, true), finishEditing.bind(this, false));
     UI.InplaceEditor.startEditing(inputElement, config);
   }
 
   /**
    * @param {string} url
    * @param {boolean} enabled
    */
   _setBreakpoint(url, enabled) {
     if (this._breakpointElements.has(url)) {
       this._breakpointElements.get(url)._checkboxElement.checked = enabled;
       return;
     }
 
     var element = createElement('li');

[dgozman, 2017/05/30 21:53:39]

li -> div

     element._url = url;
     element.addEventListener('contextmenu', this._contextMenu.bind(this, url), true);
 
     var title = url ? Common.UIString('URL contains "%s"', url) : Common.UIString('Any XHR');
     var label = UI.CheckboxLabel.create(title, enabled);
     element.appendChild(label);
     label.checkboxElement.addEventListener('click', this._checkboxClicked.bind(this, url), false);
     element._checkboxElement = label.checkboxElement;
 
     label.classList.add('cursor-auto');
     label.textElement.addEventListener('dblclick', this._labelClicked.bind(this, url), false);
 
-    var currentElement = /** @type {?Element} */ (this.listElement.firstChild);
+    var currentElement = /** @type {?Element} */ (this._listElement.firstChild);
     while (currentElement) {
       if (currentElement._url && currentElement._url < element._url)
         break;
       currentElement = /** @type {?Element} */ (currentElement.nextSibling);
     }
-    this.addListElement(element, currentElement);
+    this._addListElement(element, currentElement);
     this._breakpointElements.set(url, element);
   }
 
   /**
    * @param {string} url
    */
   _removeBreakpoint(url) {
     var element = this._breakpointElements.get(url);
     if (!element)
       return;
 
-    this.removeListElement(element);
+    this._removeListElement(element);
     this._breakpointElements.delete(url);
   }
 
+  /**
+   * @param {!Element} element
+   * @param {?Node} beforeNode
+   */
+  _addListElement(element, beforeNode) {
+    this._listElement.insertBefore(element, beforeNode);
+    if (this._emptyElement.parentElement === this.contentElement)
+      this.contentElement.replaceChild(this._listElement, this._emptyElement);

[dgozman, 2017/05/30 21:53:39]

Toggle hidden class.

[luoe, 2017/05/31 03:09:24]

Done.

+  }
+
+  _removeListElement(element) {
+    this._listElement.removeChild(element);
+    if (!this._listElement.firstChild && this._listElement.parentElement === this.contentElement)
+      this.contentElement.replaceChild(this._emptyElement, this._listElement);
+  }
+
   _contextMenu(url, event) {
     var contextMenu = new UI.ContextMenu(event);
 
     /**
      * @this {Sources.XHRBreakpointsSidebarPane}
      */
     function removeBreakpoint() {
       SDK.domDebuggerManager.removeXHRBreakpoint(url);
       this._removeBreakpoint(url);
     }
@@ skipping 16 matching lines @@
   }
 
   _checkboxClicked(url, event) {
     SDK.domDebuggerManager.toggleXHRBreakpoint(url, event.target.checked);
   }
 
   _labelClicked(url) {
     var element = this._breakpointElements.get(url) || null;
     var inputElement = createElementWithClass('span', 'breakpoint-condition');
     inputElement.textContent = url;
-    this.listElement.insertBefore(inputElement, element);
+    this._listElement.insertBefore(inputElement, element);
     element.classList.add('hidden');
 
     /**
      * @param {boolean} accept
      * @param {!Element} e
      * @param {string} text
      * @this {Sources.XHRBreakpointsSidebarPane}
      */
     function finishEditing(accept, e, text) {
-      this.removeListElement(inputElement);
+      this._removeListElement(inputElement);
       if (accept) {
         SDK.domDebuggerManager.removeXHRBreakpoint(url);
         this._removeBreakpoint(url);
         var enabled = element ? element._checkboxElement.checked : true;
         SDK.domDebuggerManager.addXHRBreakpoint(text, enabled);
         this._setBreakpoint(text, enabled);
       } else {
         element.classList.remove('hidden');
       }
     }
@@ skipping 27 matching lines @@
     element.classList.add('breakpoint-hit');
     this._highlightedElement = element;
   }
 
   _restoreBreakpoints() {
     var breakpoints = SDK.domDebuggerManager.xhrBreakpoints();
     for (var url of breakpoints.keys())
       this._setBreakpoint(url, breakpoints.get(url));
   }
 };