Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1613)

Issue 290083007: Use LayerTreeHostImpl id instead of its address as id in trace events (Closed)

Created:
6 years, 7 months ago by caseq
Modified:
6 years, 7 months ago
Reviewers:
danakj, brianderson
CC:
chromium-reviews, cc-bugs_chromium.org, nduca
Visibility:
Public.

Description

Use LayerTreeHostImpl id instead of its address as id in trace events This would let us link it to the inspected page in DevTools, as we already do with other events coming from LTHI. BUG=361045 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
caseq
Dana, Brian, please take a look.
6 years, 7 months ago (2014-05-16 15:33:56 UTC) #1
danakj
LGTM
6 years, 7 months ago (2014-05-16 15:34:38 UTC) #2
danakj
Will we need to update anything in traceviewer for this?
6 years, 7 months ago (2014-05-16 15:34:55 UTC) #3
caseq
On 2014/05/16 15:34:55, danakj wrote: Thanks! > Will we need to update anything in traceviewer ...
6 years, 7 months ago (2014-05-16 15:40:59 UTC) #4
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 7 months ago (2014-05-16 15:41:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/290083007/1
6 years, 7 months ago (2014-05-16 15:41:24 UTC) #6
brianderson
lgtm
6 years, 7 months ago (2014-05-16 16:25:01 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 19:10:34 UTC) #8
Message was sent while issue was closed.
Change committed as 271074

Powered by Google App Engine
This is Rietveld 408576698