Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: base/prefs/pref_member.h

Issue 290083006: Store a stacktrace of PrefService destruction in PrefChangeRegistrar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compilation Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/prefs/pref_change_registrar.cc ('k') | base/prefs/pref_member.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/prefs/pref_member.h
diff --git a/base/prefs/pref_member.h b/base/prefs/pref_member.h
index 17f5b447eb4a6f3a1f58985b6e7be0b7dc718c5c..2c2e8e6492b49e8b4ab443a8c4699d0045eaf9d3 100644
--- a/base/prefs/pref_member.h
+++ b/base/prefs/pref_member.h
@@ -117,6 +117,9 @@ class BASE_PREFS_EXPORT PrefMemberBase : public PrefObserver {
// PrefObserver
virtual void OnPreferenceChanged(PrefService* service,
const std::string& pref_name) OVERRIDE;
+ // TODO(battre): Remove function (debugging tool for crbug.com/373435).
+ virtual void SetPrefServiceDestructionTrace(
+ const std::string& stack_trace) OVERRIDE;
void VerifyValuePrefName() const {
DCHECK(!pref_name_.empty());
@@ -144,6 +147,8 @@ class BASE_PREFS_EXPORT PrefMemberBase : public PrefObserver {
std::string pref_name_;
NamedChangeCallback observer_;
PrefService* prefs_;
+ // TODO(battre): Remove attribute (debugging tool for crbug.com/373435).
+ std::string pref_service_destruction_;
protected:
bool setting_value_;
« no previous file with comments | « base/prefs/pref_change_registrar.cc ('k') | base/prefs/pref_member.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698