Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: base/prefs/pref_change_registrar.h

Issue 290083006: Store a stacktrace of PrefService destruction in PrefChangeRegistrar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compilation Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/prefs/pref_change_registrar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/prefs/pref_change_registrar.h
diff --git a/base/prefs/pref_change_registrar.h b/base/prefs/pref_change_registrar.h
index a914bea7d48cec7c4cf2149d7525c54dc10a76b2..84640a9dad4e7b85c946c0dd034cd8952223d3cb 100644
--- a/base/prefs/pref_change_registrar.h
+++ b/base/prefs/pref_change_registrar.h
@@ -66,6 +66,9 @@ class BASE_PREFS_EXPORT PrefChangeRegistrar : public PrefObserver {
// PrefObserver:
virtual void OnPreferenceChanged(PrefService* service,
const std::string& pref_name) OVERRIDE;
+ // TODO(battre): Delete function. See crbug.com/373435.
+ virtual void SetPrefServiceDestructionTrace(
+ const std::string& stack_trace) OVERRIDE;
static void InvokeUnnamedCallback(const base::Closure& callback,
const std::string& pref_name);
@@ -74,6 +77,8 @@ class BASE_PREFS_EXPORT PrefChangeRegistrar : public PrefObserver {
ObserverMap observers_;
PrefService* service_;
+ // TODO(battre): Remove attribute (debugging tool for crbug.com/373435).
+ std::string pref_service_destruction_;
DISALLOW_COPY_AND_ASSIGN(PrefChangeRegistrar);
};
« no previous file with comments | « no previous file | base/prefs/pref_change_registrar.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698