Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2043)

Side by Side Diff: base/prefs/pref_notifier_impl_unittest.cc

Issue 290083006: Store a stacktrace of PrefService destruction in PrefChangeRegistrar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compilation Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/prefs/pref_notifier_impl.cc ('k') | base/prefs/pref_observer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/callback.h" 6 #include "base/callback.h"
7 #include "base/prefs/mock_pref_change_callback.h" 7 #include "base/prefs/mock_pref_change_callback.h"
8 #include "base/prefs/pref_notifier_impl.h" 8 #include "base/prefs/pref_notifier_impl.h"
9 #include "base/prefs/pref_observer.h" 9 #include "base/prefs/pref_observer.h"
10 #include "base/prefs/pref_registry_simple.h" 10 #include "base/prefs/pref_registry_simple.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 using PrefNotifierImpl::OnPreferenceChanged; 73 using PrefNotifierImpl::OnPreferenceChanged;
74 using PrefNotifierImpl::OnInitializationCompleted; 74 using PrefNotifierImpl::OnInitializationCompleted;
75 }; 75 };
76 76
77 class PrefObserverMock : public PrefObserver { 77 class PrefObserverMock : public PrefObserver {
78 public: 78 public:
79 PrefObserverMock() {} 79 PrefObserverMock() {}
80 virtual ~PrefObserverMock() {} 80 virtual ~PrefObserverMock() {}
81 81
82 MOCK_METHOD2(OnPreferenceChanged, void(PrefService*, const std::string&)); 82 MOCK_METHOD2(OnPreferenceChanged, void(PrefService*, const std::string&));
83
84 // TODO(battre) Remove function. See crbug.com/373435.
85 MOCK_METHOD1(SetPrefServiceDestructionTrace, void(const std::string&));
83 }; 86 };
84 87
85 // Test fixture class. 88 // Test fixture class.
86 class PrefNotifierTest : public testing::Test { 89 class PrefNotifierTest : public testing::Test {
87 protected: 90 protected:
88 virtual void SetUp() { 91 virtual void SetUp() {
89 pref_service_.registry()->RegisterBooleanPref(kChangedPref, true); 92 pref_service_.registry()->RegisterBooleanPref(kChangedPref, true);
90 pref_service_.registry()->RegisterBooleanPref(kUnchangedPref, true); 93 pref_service_.registry()->RegisterBooleanPref(kUnchangedPref, true);
91 } 94 }
92 95
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 EXPECT_CALL(obs2_, OnPreferenceChanged(&pref_service_, kChangedPref)); 214 EXPECT_CALL(obs2_, OnPreferenceChanged(&pref_service_, kChangedPref));
212 notifier.OnPreferenceChanged(kChangedPref); 215 notifier.OnPreferenceChanged(kChangedPref);
213 Mock::VerifyAndClearExpectations(&obs1_); 216 Mock::VerifyAndClearExpectations(&obs1_);
214 Mock::VerifyAndClearExpectations(&obs2_); 217 Mock::VerifyAndClearExpectations(&obs2_);
215 218
216 notifier.RemovePrefObserver(kChangedPref, &obs2_); 219 notifier.RemovePrefObserver(kChangedPref, &obs2_);
217 notifier.RemovePrefObserver(kUnchangedPref, &obs2_); 220 notifier.RemovePrefObserver(kUnchangedPref, &obs2_);
218 } 221 }
219 222
220 } // namespace 223 } // namespace
OLDNEW
« no previous file with comments | « base/prefs/pref_notifier_impl.cc ('k') | base/prefs/pref_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698