Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 290083005: Added test checking that m-p user adding UI is visible after show. (Closed)

Created:
6 years, 7 months ago by dzhioev (left Google)
Modified:
6 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Added test checking that m-p user adding UI is visible after show. We have been reported that user adding UI was invisible once in M35. I was not able to find the source of this problem, maybe it is gone already. I wrote this test, just in case. BUG=362153 TEST=UserAddingScreenTest.*ScreenVisibility Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271030

Patch Set 1 #

Patch Set 2 : Merge conflicts resolved. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc View 1 3 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dzhioev (left Google)
6 years, 7 months ago (2014-05-16 12:04:53 UTC) #1
Nikita (slow)
lgtm
6 years, 7 months ago (2014-05-16 12:15:40 UTC) #2
dzhioev (left Google)
The CQ bit was checked by dzhioev@chromium.org
6 years, 7 months ago (2014-05-16 12:23:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/290083005/1
6 years, 7 months ago (2014-05-16 12:23:30 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 12:52:29 UTC) #5
dzhioev (left Google)
The CQ bit was checked by dzhioev@chromium.org
6 years, 7 months ago (2014-05-16 12:54:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/290083005/20001
6 years, 7 months ago (2014-05-16 12:54:50 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 16:25:07 UTC) #8
Message was sent while issue was closed.
Change committed as 271030

Powered by Google App Engine
This is Rietveld 408576698