Handle app custom icon via aura::Window property.

chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc

Index: chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
diff --git a/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc b/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
index fbf6bd2e293ab78573abb0828c14fd19c6048457..d4dbb0524866c50878444592f524604e13324416 100644
--- a/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
+++ b/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
@@ -76,24 +76,6 @@ void ExtensionAppWindowLauncherController::AdditionalUserAddedToSession(
   registry_.insert(registry);
 }
 
-void ExtensionAppWindowLauncherController::OnAppWindowIconChanged(
-    AppWindow* app_window) {

[stevenjb, 2017/05/23 17:00:19]

I think this is the only actual use of OnAppWindowIconChanged? If so we should
remove it, but I am missing where / how exactly the icon is getting updated when
AppWindow::UpdateAppIcon gets called?

[khmel, 2017/05/23 17:35:00]

I tested legacy code and found that it did not work as expected. You may read
here in my big comment problem I found with async image loading and updating it
in shelf:
https://codereview.chromium.org/2900783003/diff/20001/chrome/browser/ui/views...

Now we have reliable mechanism to observe kAppIconKey change.

[stevenjb, 2017/05/23 18:19:22]

OK. I believe that there may have been bugs before, especially WRT async
loading.

I'm still a little fuzzy on what is replacing
AppWindowRegistry::Observer::OnAppWindowIconChanged, and why that isn't removed
since this is the only non test usage.

-  const ash::ShelfID shelf_id = GetShelfId(app_window);
-  AppControllerMap::iterator iter = app_controller_map_.find(shelf_id);
-  if (iter == app_controller_map_.end())
-    return;
-
-  // Check if the window actually overrides its default icon. Otherwise use app
-  // icon loader provided by owner.
-  if (!app_window->HasCustomIcon() || app_window->app_icon().IsEmpty())
-    return;
-
-  ExtensionAppWindowLauncherItemController* controller = iter->second;
-  controller->set_image_set_by_controller(true);
-  owner()->SetLauncherItemImage(controller->shelf_id(),
-                                app_window->app_icon().AsImageSkia());
-}
-
 void ExtensionAppWindowLauncherController::OnAppWindowShown(
     AppWindow* app_window,
     bool was_hidden) {
@@ -148,19 +130,14 @@ void ExtensionAppWindowLauncherController::RegisterApp(AppWindow* app_window) {
     controller->AddAppWindow(app_window);
   } else {
     std::unique_ptr<ExtensionAppWindowLauncherItemController> controller =
-        base::MakeUnique<ExtensionAppWindowLauncherItemController>(shelf_id);
+        base::MakeUnique<ExtensionAppWindowLauncherItemController>(shelf_id,
+                                                                   owner());
     app_controller_map_[shelf_id] = controller.get();
     controller->AddAppWindow(app_window);
 
     // Check for any existing pinned shelf item with a matching |shelf_id|.
     if (!owner()->GetItem(shelf_id)) {
       owner()->CreateAppLauncherItem(std::move(controller), status);
-      // Restore any existing app icon and flag as set.
-      if (app_window->HasCustomIcon() && !app_window->app_icon().IsEmpty()) {
-        owner()->SetLauncherItemImage(shelf_id,
-                                      app_window->app_icon().AsImageSkia());
-        app_controller_map_[shelf_id]->set_image_set_by_controller(true);
-      }
     } else {
       owner()->shelf_model()->SetShelfItemDelegate(shelf_id,
                                                    std::move(controller));