Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc

Issue 2900783003: Handle app custom icon via aura::Window property. (Closed)
Patch Set: fix mac compile Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc
diff --git a/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc b/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc
index 41d5953e1cda765dc682a8263440d1ea3a7683d6..e5a924c6743e8cba6f2d2fb9be6eaf2424989358 100644
--- a/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc
+++ b/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc
@@ -27,7 +27,7 @@ void AppWindowLauncherItemController::AddWindow(ui::BaseWindow* app_window) {
aura::Window* window = app_window->GetNativeWindow();
if (window)
observed_windows_.Add(window);
- UpdateLauncherItem();
+ UpdateShelfItemIcon();
}
AppWindowLauncherItemController::WindowList::iterator
@@ -51,7 +51,7 @@ void AppWindowLauncherItemController::RemoveWindow(ui::BaseWindow* app_window) {
return;
}
windows_.erase(iter);
- UpdateLauncherItem();
+ UpdateShelfItemIcon();
}
ui::BaseWindow* AppWindowLauncherItemController::GetAppWindow(
@@ -66,7 +66,7 @@ void AppWindowLauncherItemController::SetActiveWindow(aura::Window* window) {
ui::BaseWindow* app_window = GetAppWindow(window);
if (app_window)
last_active_window_ = app_window;
- UpdateLauncherItem();
+ UpdateShelfItemIcon();
}
AppWindowLauncherItemController*
@@ -143,6 +143,8 @@ void AppWindowLauncherItemController::OnWindowPropertyChanged(
status = ash::STATUS_RUNNING;
}
ChromeLauncherController::instance()->SetItemStatus(shelf_id(), status);
+ } else if (key == aura::client::kAppIconKey) {
+ UpdateShelfItemIcon();
}
}
@@ -174,3 +176,25 @@ AppWindowLauncherItemController::ActivateOrAdvanceToNextAppWindow(
}
return ash::SHELF_ACTION_NONE;
}
+
+void AppWindowLauncherItemController::UpdateShelfItemIcon() {
+ // Set the shelf item icon from the kAppIconKey property of the current
+ // (or most recently) active window. If there is no valid icon, ask
+ // ChromeLauncherController to update the icon.
+ const gfx::ImageSkia* app_icon = nullptr;
+ ui::BaseWindow* last_active_window = GetLastActiveWindow();
+ if (last_active_window && last_active_window->GetNativeWindow()) {
+ app_icon = last_active_window->GetNativeWindow()->GetProperty(
+ aura::client::kAppIconKey);
+ }
+ // TODO(khmel): Remove using image_set_by_controller
+ if (app_icon && !app_icon->isNull()) {
+ set_image_set_by_controller(true);
+ ChromeLauncherController::instance()->SetLauncherItemImage(shelf_id(),
+ *app_icon);
+ } else if (image_set_by_controller()) {
+ set_image_set_by_controller(false);
+ ChromeLauncherController::instance()->UpdateLauncherItemImage(
+ shelf_id().app_id);
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698