Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc

Issue 2900783003: Handle app custom icon via aura::Window property. (Closed)
Patch Set: cleanup Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
diff --git a/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc b/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
index fbf6bd2e293ab78573abb0828c14fd19c6048457..d4dbb0524866c50878444592f524604e13324416 100644
--- a/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
+++ b/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
@@ -76,24 +76,6 @@ void ExtensionAppWindowLauncherController::AdditionalUserAddedToSession(
registry_.insert(registry);
}
-void ExtensionAppWindowLauncherController::OnAppWindowIconChanged(
- AppWindow* app_window) {
- const ash::ShelfID shelf_id = GetShelfId(app_window);
- AppControllerMap::iterator iter = app_controller_map_.find(shelf_id);
- if (iter == app_controller_map_.end())
- return;
-
- // Check if the window actually overrides its default icon. Otherwise use app
- // icon loader provided by owner.
- if (!app_window->HasCustomIcon() || app_window->app_icon().IsEmpty())
- return;
-
- ExtensionAppWindowLauncherItemController* controller = iter->second;
- controller->set_image_set_by_controller(true);
- owner()->SetLauncherItemImage(controller->shelf_id(),
- app_window->app_icon().AsImageSkia());
-}
-
void ExtensionAppWindowLauncherController::OnAppWindowShown(
AppWindow* app_window,
bool was_hidden) {
@@ -148,19 +130,14 @@ void ExtensionAppWindowLauncherController::RegisterApp(AppWindow* app_window) {
controller->AddAppWindow(app_window);
} else {
std::unique_ptr<ExtensionAppWindowLauncherItemController> controller =
- base::MakeUnique<ExtensionAppWindowLauncherItemController>(shelf_id);
+ base::MakeUnique<ExtensionAppWindowLauncherItemController>(shelf_id,
+ owner());
app_controller_map_[shelf_id] = controller.get();
controller->AddAppWindow(app_window);
// Check for any existing pinned shelf item with a matching |shelf_id|.
if (!owner()->GetItem(shelf_id)) {
owner()->CreateAppLauncherItem(std::move(controller), status);
- // Restore any existing app icon and flag as set.
- if (app_window->HasCustomIcon() && !app_window->app_icon().IsEmpty()) {
- owner()->SetLauncherItemImage(shelf_id,
- app_window->app_icon().AsImageSkia());
- app_controller_map_[shelf_id]->set_image_set_by_controller(true);
- }
} else {
owner()->shelf_model()->SetShelfItemDelegate(shelf_id,
std::move(controller));

Powered by Google App Engine
This is Rietveld 408576698