chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc - Issue 2900783003: Handle app custom icon via aura::Window property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

Issue 2900783003: Handle app custom icon via aura::Window property. (Closed)

Patch Set: nits, discard owner from _item_controller, make SetAppIcon non-static Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc ('k') | chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.h » ('j') | components/exo/shell_surface.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

index 4b9706709d1a71c767af509263668c8acc2a93c1..18f12ff7b5d402dc56be615541535c5eb45f02e0 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

@@ -2336,6 +2336,7 @@ TEST_P(ChromeLauncherControllerWithArcTest, ArcCustomAppIcon) {

// Set custom icon on active item. Icon should change to custom.

arc_test_.app_instance()->SendTaskDescription(2, std::string(), png_data);

+ base::RunLoop().RunUntilIdle();

EXPECT_TRUE(item_delegate->image_set_by_controller());

// Switch back to the item without custom icon. Icon should be changed to