chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc - Issue 2900783003: Handle app custom icon via aura::Window property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc

Issue 2900783003: Handle app custom icon via aura::Window property. (Closed)

Patch Set: nits rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc ('K') | « chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc ('k') | chrome/browser/ui/ash/launcher/arc_app_window.h » ('j') | chrome/browser/ui/ash/launcher/chrome_launcher_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc

diff --git a/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc b/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc

index 97c20fcf43d4871992e7e8fdde5639e138b011ed..652503a2cd54aecb65e7bc7b46ddea961e907c79 100644

--- a/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc

+++ b/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc

@@ -164,9 +164,7 @@ base::TimeDelta ArcAppDeferredLauncherController::GetActiveTime(

}

void ArcAppDeferredLauncherController::UpdateApp(const std::string& app_id) {

msw 2017/06/01 19:47:28 optional nit: rename UpdateShelfItemIcon or Update

khmel 2017/06/01 21:55:46 Done.

- AppIconLoader* icon_loader = owner_->GetAppIconLoaderForApp(app_id);

- if (icon_loader)

- icon_loader->UpdateImage(app_id);

+ owner_->UpdateLauncherItemImage(app_id);

}

void ArcAppDeferredLauncherController::UpdateApps() {