Handle app custom icon via aura::Window property.

extensions/browser/app_window/app_window.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/app_window/app_window.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
@@ skipping 31 matching lines @@
 #include "extensions/browser/extension_web_contents_observer.h"
 #include "extensions/browser/extensions_browser_client.h"
 #include "extensions/browser/notification_types.h"
 #include "extensions/browser/process_manager.h"
 #include "extensions/browser/suggest_permission_util.h"
 #include "extensions/browser/view_type_utils.h"
 #include "extensions/common/draggable_region.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest_handlers/icons_handler.h"
 #include "extensions/common/permissions/permissions_data.h"
-#include "extensions/grit/extensions_browser_resources.h"
+#include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/skia/include/core/SkRegion.h"
-#include "ui/base/resource/resource_bundle.h"
 #include "ui/display/display.h"
 #include "ui/display/screen.h"
 #include "ui/events/keycodes/keyboard_codes.h"
-#include "ui/gfx/image/image_skia_operations.h"
 
 #if !defined(OS_MACOSX)
 #include "components/prefs/pref_service.h"
 #include "extensions/browser/pref_names.h"
 #endif
 
 using content::BrowserContext;
 using content::ConsoleMessageLevel;
 using content::WebContents;
 using web_modal::WebContentsModalDialogHost;
@@ skipping 217 matching lines @@
   window_key_ = new_params.window_key;
 
   // Windows cannot be always-on-top in fullscreen mode for security reasons.
   cached_always_on_top_ = new_params.always_on_top;
   if (new_params.state == ui::SHOW_STATE_FULLSCREEN)
     new_params.always_on_top = false;
 
   requested_alpha_enabled_ = new_params.alpha_enabled;
   is_ime_window_ = params.is_ime_window;
   show_in_shelf_ = params.show_in_shelf;
-  window_icon_url_ = params.window_icon_url;
 
   AppWindowClient* app_window_client = AppWindowClient::Get();
   native_app_window_.reset(
       app_window_client->CreateNativeAppWindow(this, &new_params));
 
   helper_.reset(new AppWebContentsHelper(
       browser_context_, extension_id_, web_contents(), app_delegate_.get()));
 
-  UpdateExtensionAppIcon();
-  // Download showInShelf=true window icon.
-  if (window_icon_url_.is_valid())
-    SetAppIconUrl(window_icon_url_);
+  native_app_window_->UpdateWindowIcon();
+
+  if (params.window_icon_url.is_valid())
+    SetAppIconUrl(params.window_icon_url);
 
   AppWindowRegistry::Get(browser_context_)->AddAppWindow(this);
 
   if (new_params.hidden) {
     // Although the window starts hidden by default, calling Hide() here
     // notifies observers of the window being hidden.
     Hide();
   } else {
     // Panels are not activated by default.
     Show(window_type_is_panel() || !new_params.focused ? SHOW_INACTIVE
@@ skipping 235 matching lines @@
       web_contents()->GetController().GetLastCommittedEntry() : nullptr;
   if (!entry || entry->GetTitle().empty()) {
     title = base::UTF8ToUTF16(extension->name());
   } else {
     title = web_contents()->GetTitle();
   }
   base::RemoveChars(title, base::ASCIIToUTF16("\n"), &title);
   return title;
 }
 
-bool AppWindow::HasCustomIcon() const {
-  return window_icon_url_.is_valid() || app_icon_url_.is_valid();
-}
-
 void AppWindow::SetAppIconUrl(const GURL& url) {
   // Avoid using any previous icons that were being downloaded.
   image_loader_ptr_factory_.InvalidateWeakPtrs();
-
-  // Reset |app_icon_image_| to abort pending image load (if any).
-  if (!show_in_shelf_) {
-    app_icon_image_.reset();
-    app_icon_url_ = url;
-  } else {
-    window_icon_url_ = url;
-  }
-
+  app_icon_url_ = url;
   web_contents()->DownloadImage(
       url,
       true,   // is a favicon
       0,      // no maximum size
       false,  // normal cache policy
       base::Bind(&AppWindow::DidDownloadFavicon,
                  image_loader_ptr_factory_.GetWeakPtr()));
 }
 
 void AppWindow::UpdateShape(std::unique_ptr<SkRegion> region) {
   native_app_window_->UpdateShape(std::move(region));
 }
 
 void AppWindow::UpdateDraggableRegions(
     const std::vector<DraggableRegion>& regions) {
   native_app_window_->UpdateDraggableRegions(regions);
 }
 
 void AppWindow::UpdateAppIcon(const gfx::Image& image) {
-  // Set the showInShelf=true window icon and add the app_icon_image_
-  // as a badge. If the image is empty, set the default app icon placeholder
-  // as the base image.
-  if (window_icon_url_.is_valid() && app_icon_image_ &&
-      !app_icon_image_->image().IsEmpty()) {
-    gfx::Image base_image =
-        !image.IsEmpty()
-            ? image
-            : gfx::Image(*ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
-                  IDR_APP_DEFAULT_ICON));
-    // Scale the icon to EXTENSION_ICON_LARGE.
-    const int large_icon_size = extension_misc::EXTENSION_ICON_LARGE;
-    if (base_image.Width() != large_icon_size ||
-        base_image.Height() != large_icon_size) {
-      gfx::ImageSkia resized_image =
-          gfx::ImageSkiaOperations::CreateResizedImage(
-              base_image.AsImageSkia(), skia::ImageOperations::RESIZE_BEST,
-              gfx::Size(large_icon_size, large_icon_size));
-      app_icon_ = gfx::Image(gfx::ImageSkiaOperations::CreateIconWithBadge(
-          resized_image, app_icon_image_->image_skia()));
-    } else {
-      app_icon_ = gfx::Image(gfx::ImageSkiaOperations::CreateIconWithBadge(
-          base_image.AsImageSkia(), app_icon_image_->image_skia()));
-    }
-  } else {
-    if (image.IsEmpty())
-      return;
-
-    app_icon_ = image;
-  }
+  if (image.IsEmpty())
+    return;
+  custom_app_icon_ = image;
   native_app_window_->UpdateWindowIcon();
-  AppWindowRegistry::Get(browser_context_)->AppWindowIconChanged(this);
 }
 
 void AppWindow::SetFullscreen(FullscreenType type, bool enable) {
   DCHECK_NE(FULLSCREEN_TYPE_NONE, type);
 
   if (enable) {
 #if !defined(OS_MACOSX)
     // Do not enter fullscreen mode if disallowed by pref.
     // TODO(bartfab): Add a test once it becomes possible to simulate a user
     // gesture. http://crbug.com/174178
@@ skipping 164 matching lines @@
 
 //------------------------------------------------------------------------------
 // Private methods
 
 void AppWindow::DidDownloadFavicon(
     int id,
     int http_status_code,
     const GURL& image_url,
     const std::vector<SkBitmap>& bitmaps,
     const std::vector<gfx::Size>& original_bitmap_sizes) {
-  if (((image_url != app_icon_url_) && (image_url != window_icon_url_)) ||
-      bitmaps.empty()) {
+  if (image_url != app_icon_url_ || bitmaps.empty())
     return;
-  }
 
   // Bitmaps are ordered largest to smallest. Choose the smallest bitmap
   // whose height >= the preferred size.
   int largest_index = 0;
   for (size_t i = 1; i < bitmaps.size(); ++i) {
     if (bitmaps[i].height() < app_delegate_->PreferredIconSize())
       break;
     largest_index = i;
   }
   const SkBitmap& largest = bitmaps[largest_index];
   UpdateAppIcon(gfx::Image::CreateFrom1xBitmap(largest));
 }
 
-void AppWindow::OnExtensionIconImageChanged(IconImage* image) {
-  DCHECK_EQ(app_icon_image_.get(), image);
-
-  // Update app_icon if no valid window icon url is set.
-  if (!window_icon_url_.is_valid())
-    UpdateAppIcon(gfx::Image(app_icon_image_->image_skia()));
-}
-
-void AppWindow::UpdateExtensionAppIcon() {
-  // Avoid using any previous app icons were being downloaded.
-  image_loader_ptr_factory_.InvalidateWeakPtrs();
-
-  const Extension* extension = GetExtension();
-  if (!extension)
-    return;
-
-  gfx::ImageSkia app_default_icon =
-      *ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
-          IDR_APP_DEFAULT_ICON);
-
-  app_icon_image_.reset(new IconImage(browser_context(),
-                                      extension,
-                                      IconsInfo::GetIcons(extension),
-                                      app_delegate_->PreferredIconSize(),
-                                      app_default_icon,
-                                      this));
-
-  // Triggers actual image loading with 1x resources. The 2x resource will
-  // be handled by IconImage class when requested.
-  app_icon_image_->image_skia().GetRepresentation(1.0f);
-}
-
 void AppWindow::SetNativeWindowFullscreen() {
   native_app_window_->SetFullscreen(fullscreen_types_);
 
   RestoreAlwaysOnTop();
 }
 
 bool AppWindow::IntersectsWithTaskbar() const {
 #if defined(OS_WIN)
   display::Screen* screen = display::Screen::GetScreen();
   gfx::Rect window_bounds = native_app_window_->GetRestoredBounds();
@@ skipping 244 matching lines @@
         region.bounds.x(),
         region.bounds.y(),
         region.bounds.right(),
         region.bounds.bottom(),
         region.draggable ? SkRegion::kUnion_Op : SkRegion::kDifference_Op);
   }
   return sk_region;
 }
 
 }  // namespace extensions