Allow gaming_seat to use ozone gamepad as back-end

components/exo/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//chrome/common/features.gni")
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 
 source_set("exo") {
   sources = [
     "buffer.cc",
     "buffer.h",
     "compositor_frame_sink_holder.cc",
     "compositor_frame_sink_holder.h",
     "display.cc",
     "display.h",
-    "gaming_seat.cc",
     "gaming_seat.h",
     "keyboard.cc",
     "keyboard.h",
     "keyboard_delegate.h",
     "keyboard_device_configuration_delegate.h",
     "notification_surface.cc",
     "notification_surface.h",
     "notification_surface_manager.h",
     "pointer.cc",
     "pointer.h",
@@ skipping 36 matching lines @@
     "//ui/display/manager",
     "//ui/events/devices:devices",
     "//ui/gfx",
     "//ui/gfx/geometry",
     "//ui/gl",
     "//ui/views",
     "//ui/views/mus",
     "//ui/wm",
   ]
 
-  if (use_ozone) {
+  if (use_ozone && enable_ozone_gamepad_in_exo) {

[reveman, 2017/06/05 22:48:03]

hm, is use_ozone needed? isn't that automatic from _ozone file name prefix?
anyhow, probably shouldn't be setting enable_ozone_gamepad_in_exo to true unless
when building for ozone

[jkwang, 2017/06/06 20:03:06]

Done.

+    defines = [ "USE_OZONE_GAMEPAD" ]
+    sources += [ "gaming_seat_ozone.cc" ]
     deps += [ "//ui/ozone" ]
+    deps += [ "//ui/events/ozone:events_ozone_evdev" ]
+  } else {
+    sources += [ "gaming_seat.cc" ]
   }
 
   if (is_chromeos) {
     deps += [ "//chromeos" ]
   }
 }
 
 source_set("test_support") {
   testonly = true
 
@@ skipping 19 matching lines @@
     "//ui/wm:wm",
   ]
 }
 
 source_set("unit_tests") {
   testonly = true
 
   sources = [
     "buffer_unittest.cc",
     "display_unittest.cc",
-    "gaming_seat_unittest.cc",
     "keyboard_unittest.cc",
     "pointer_unittest.cc",
     "shared_memory_unittest.cc",
     "shell_surface_unittest.cc",
     "sub_surface_unittest.cc",
     "surface_unittest.cc",
     "touch_unittest.cc",
   ]
 
   deps = [
@@ skipping 16 matching lines @@
     "//ui/aura",
     "//ui/events:dom_keycode_converter",
     "//ui/events:test_support",
     "//ui/gfx",
     "//ui/keyboard",
     "//ui/message_center",
     "//ui/views",
     "//ui/wm",
   ]
 
-  if (use_ozone) {
-    deps += [ "//ui/ozone" ]
+  if (use_ozone && enable_ozone_gamepad_in_exo) {
+    sources += [
+      "../../ui/events/ozone/gamepad/gamepad_event.cc",

[reveman, 2017/06/05 22:48:03]

I think you can include this unconditionally when use_ozone is true

[jkwang, 2017/06/06 20:03:06]

Won't compile. The test case is specific for one impl.

+      "gaming_seat_ozone_unittest.cc",
+    ]
+  } else {
+    sources += [ "gaming_seat_unittest.cc" ]
   }
 }
 
 test("exo_unittests") {
   sources = [
     "../../ash/test/ash_test_suite.cc",
     "../../ash/test/ash_test_suite.h",
     "test/run_all_unittests.cc",
   ]
 
@@ skipping 15 matching lines @@
   data_deps = [
     "//ash/strings:ash_test_strings",
     "//ash/resources:ash_test_resources_100_percent",
     "//ash/resources:ash_test_resources_200_percent",
   ]
 
   if (is_linux) {
     deps += [ "//components/exo/wayland:unit_tests" ]
   }
 }