Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2900753002: Update status and expectations. (Closed)

Created:
3 years, 7 months ago by ahe
Modified:
3 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Kevin Millikin (Google)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+637 lines, -12 lines) Patch
M pkg/front_end/test/fasta/kompile.status View 2 chunks +271 lines, -11 lines 0 comments Download
A pkg/front_end/testcases/inference/assign_local.dart.dartk.expect View 1 chunk +19 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/coerce_bottom_and_null_types.dart.dartk.expect View 1 chunk +21 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/constructors_downwards_with_constraint.dart.dartk.expect View 1 chunk +22 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/constructors_too_many_positional_arguments.dart.dartk.expect View 1 chunk +12 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/dont_infer_type_when_initializer_is_null.dart.dartk.expect View 1 chunk +11 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/downwards_inference_assignment_statements.dart.dartk.expect View 1 chunk +9 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/downwards_inference_for_each.dart.dartk.expect View 1 chunk +15 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/downwards_inference_yield_yield_star.dart.dartk.expect View 1 chunk +21 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/future_union_downwards_generic_method_with_future_return.dart.dartk.expect View 1 chunk +15 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/future_union_upwards_generic_methods.dart.dartk.expect View 1 chunk +28 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/generic_methods_infer_js_builtin.dart.dartk.expect View 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_type_on_var.dart.dartk.expect View 1 chunk +11 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_type_on_var2.dart.dartk.expect View 1 chunk +10 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_type_regardless_of_declaration_order_or_cycles.dart.dartk.expect View 1 chunk +26 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_type_regardless_of_declaration_order_or_cycles_b.dart.dartk.expect View 1 chunk +10 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_types_on_loop_indices_for_loop_with_inference.dart.dartk.expect View 1 chunk +9 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/inferred_type_block_closure_no_args_no_return.dart.dartk.expect View 1 chunk +6 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/instantiate_to_bounds_invoke_constructor_no_bound.dart.dartk.expect View 1 chunk +12 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/list_literals.dart.dartk.expect View 1 chunk +21 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/list_literals_can_infer_null_bottom.dart.dartk.expect View 1 chunk +10 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/map_literals.dart.dartk.expect View 1 chunk +22 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/map_literals_can_infer_null.dart.dartk.expect View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/no_error_when_declared_type_is_num_and_assigned_null.dart.dartk.expect View 1 chunk +11 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/null_coalescing_operator.dart.dartk.expect View 1 chunk +9 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/null_coalescing_operator_2.dart.dartk.expect View 1 chunk +8 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_in_list_untyped.dart.dartk.expect View 1 chunk +8 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_in_map_untyped.dart.dartk.expect View 1 chunk +8 lines, -0 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 7 months ago (2017-05-22 13:18:00 UTC) #2
Johnni Winther
lgtm
3 years, 7 months ago (2017-05-22 13:21:01 UTC) #3
ahe
3 years, 7 months ago (2017-05-22 13:22:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8f17ae77093c945949efaa3f05007fdd72ad05c9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698