bindings: Do not skip symbols in the JS -> record<> conversion.

third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "bindings/core/v8/NativeValueTraitsImpl.h"
 
 #include <utility>
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/IDLTypes.h"
 #include "bindings/core/v8/TestSequenceCallback.h"
@@ skipping 182 matching lines @@
     EXPECT_EQ(std::make_pair(String("foo"), String("Ohai")), record[2]);
   }
   {
     v8::Local<v8::Object> v8_object = v8::Object::New(scope.GetIsolate());
     EXPECT_TRUE(V8CallBoolean(v8_object->Set(
         scope.GetContext(), v8::Symbol::GetToStringTag(scope.GetIsolate()),
         ToV8(&scope, 34))));
     EXPECT_TRUE(V8CallBoolean(v8_object->Set(
         scope.GetContext(), ToV8(&scope, "foo"), ToV8(&scope, 42))));
 
-    NonThrowableExceptionState exception_state;
+    // The presence of symbols should throw a TypeError when the conversion to
+    // the record's key type is attempted.
+    DummyExceptionStateForTesting exception_state;
     const auto& record =
         NativeValueTraits<IDLRecord<IDLString, IDLShort>>::NativeValue(
             scope.GetIsolate(), v8_object, exception_state);
-    EXPECT_EQ(1U, record.size());
-    EXPECT_EQ(std::make_pair(String("foo"), int16_t(42)), record[0]);
-  }
-  {
-    v8::Local<v8::Object> v8_object = v8::Object::New(scope.GetIsolate());
-    EXPECT_TRUE(V8CallBoolean(v8_object->Set(
-        scope.GetContext(), v8::Symbol::GetToStringTag(scope.GetIsolate()),
-        ToV8(&scope, 34))));
-    EXPECT_TRUE(V8CallBoolean(v8_object->Set(
-        scope.GetContext(), ToV8(&scope, "foo"), ToV8(&scope, 42))));
-
-    NonThrowableExceptionState exception_state;
-    const auto& record =
-        NativeValueTraits<IDLRecord<IDLString, IDLShort>>::NativeValue(
-            scope.GetIsolate(), v8_object, exception_state);
-    EXPECT_EQ(1U, record.size());
-    EXPECT_EQ(std::make_pair(String("foo"), int16_t(42)), record[0]);
+    EXPECT_TRUE(record.IsEmpty());
+    EXPECT_TRUE(exception_state.HadException());
+    EXPECT_TRUE(exception_state.Message().IsEmpty());
   }
   {
     v8::Local<v8::Object> v8_parent_object =
         v8::Object::New(scope.GetIsolate());
     EXPECT_TRUE(V8CallBoolean(v8_parent_object->Set(
         scope.GetContext(), ToV8(&scope, "foo"), ToV8(&scope, 34))));
     EXPECT_TRUE(V8CallBoolean(v8_parent_object->Set(
         scope.GetContext(), ToV8(&scope, "bar"), ToV8(&scope, 512))));
     v8::Local<v8::Object> v8_object = v8::Object::New(scope.GetIsolate());
     EXPECT_TRUE(V8CallBoolean(
@@ skipping 213 matching lines @@
     const auto& boolean_sequence =
         NativeValueTraits<IDLSequence<IDLBoolean>>::NativeValue(
             scope.GetIsolate(), v8_object, exception_state);
     EXPECT_EQ(Vector<bool>({true, false}), boolean_sequence);
   }
 }
 
 }  // namespace
 
 }  // namespace blink