bindings: Do not skip symbols in the JS -> record<> conversion.

third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImpl.h

 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NativeValueTraitsImpl_h
 #define NativeValueTraitsImpl_h
 
 #include "bindings/core/v8/IDLTypes.h"
 #include "bindings/core/v8/NativeValueTraits.h"
 #include "bindings/core/v8/V8BindingForCore.h"
@@ skipping 412 matching lines @@
       return ImplType();
     }
     v8::Local<v8::Object> v8_object = v8::Local<v8::Object>::Cast(v8_value);
     v8::TryCatch block(isolate);
 
     // "3. Let keys be ? O.[[OwnPropertyKeys]]()."
     v8::Local<v8::Array> keys;
     // While we could pass v8::ONLY_ENUMERABLE below, doing so breaks
     // web-platform-tests' headers-record.html and deviates from the spec
     // algorithm.
-    // Symbols are being skipped due to
-    // https://github.com/heycam/webidl/issues/294.
     if (!v8_object
              ->GetOwnPropertyNames(context,
                                    static_cast<v8::PropertyFilter>(
-                                       v8::PropertyFilter::ALL_PROPERTIES |
-                                       v8::PropertyFilter::SKIP_SYMBOLS))
+                                       v8::PropertyFilter::ALL_PROPERTIES))
              .ToLocal(&keys)) {
       exception_state.RethrowV8Exception(block.Exception());
       return ImplType();
     }
     if (keys->Length() > ImplType::MaxCapacity()) {
       exception_state.ThrowRangeError("Array length exceeds supported limit.");
       return ImplType();
     }
 
     // "2. Let result be a new empty instance of record<K, V>."
     ImplType result;
     result.ReserveInitialCapacity(keys->Length());
 
     // The conversion algorithm needs a data structure with fast insertion at
     // the end while at the same time requiring fast checks for previous insert
     // of a given key. |seenKeys| is a key/position in |result| map that aids in
     // the latter part.
     HashMap<String, size_t> seen_keys;
 
     for (uint32_t i = 0; i < keys->Length(); ++i) {
       // "4. Repeat, for each element key of keys in List order:"
       v8::Local<v8::Value> key;
       if (!keys->Get(context, i).ToLocal(&key)) {
         exception_state.RethrowV8Exception(block.Exception());
         return ImplType();
       }
 
+      // V8's GetOwnPropertyNames() does not convert numeric property indices
+      // to strings, so we have to do it ourselves.
+      if (!key->IsName())
+        key = key->ToString(context).ToLocalChecked();
+
       // "4.1. Let desc be ? O.[[GetOwnProperty]](key)."
       v8::Local<v8::Value> desc;
-      if (!v8_object
-               ->GetOwnPropertyDescriptor(
-                   context, key->ToString(context).ToLocalChecked())
+      if (!v8_object->GetOwnPropertyDescriptor(context, key.As<v8::Name>())
                .ToLocal(&desc)) {
         exception_state.RethrowV8Exception(block.Exception());
         return ImplType();
       }
 
       // "4.2. If desc is not undefined and desc.[[Enumerable]] is true:"
       // We can call ToLocalChecked() and ToChecked() here because
       // GetOwnPropertyDescriptor is responsible for catching any exceptions
       // and failures, and if we got to this point of the code we have a proper
       // object that was not created by a user.
@@ skipping 42 matching lines @@
       }
     }
     // "5. Return result."
     return result;
   }
 };
 
 }  // namespace blink
 
 #endif  // NativeValueTraitsImpl_h