Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 2900733003: DevTools: fix offset condition in console viewport _selectedText and add tests (Closed)

Created:
3 years, 7 months ago by luoe
Modified:
3 years, 6 months ago
Reviewers:
einbinder, dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix offset condition in console viewport _selectedText and add tests When selecting non-truncated text, the selection start offset == 1 and the selected node has text length > 1, the viewport would return incorrect values for _selectedText(). It should only use the untruncated offset when it differs from the node's rendered text length. This CL corrects the condition and adds tests for other cases. BUG=722497 Review-Url: https://codereview.chromium.org/2900733003 Cr-Commit-Position: refs/heads/master@{#477809} Committed: https://chromium.googlesource.com/chromium/src/+/46ab10923ea52c1e02980027a5e098ae25e904b7

Patch Set 1 : clean #

Patch Set 2 : checking for failure #

Patch Set 3 : fix offset correction condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+423 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/inspector/console/console-copy-truncated-text.html View 2 1 chunk +196 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/console/console-copy-truncated-text-expected.txt View 1 chunk +225 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewport.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
luoe
Please take a look. This CL re-lands tests in addition to fixing a bug.
3 years, 6 months ago (2017-06-07 01:54:56 UTC) #14
einbinder
lgtm
3 years, 6 months ago (2017-06-07 02:10:00 UTC) #15
dgozman
lgtm
3 years, 6 months ago (2017-06-07 21:16:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900733003/60001
3 years, 6 months ago (2017-06-07 21:18:06 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/436799) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-06-07 21:32:06 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900733003/60001
3 years, 6 months ago (2017-06-07 21:33:42 UTC) #22
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 23:52:23 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/46ab10923ea52c1e02980027a5e0...

Powered by Google App Engine
This is Rietveld 408576698