components/autofill/content/renderer/password_form_conversion_utils.h - Issue 2900713003: [Password Manager, merge to M-59] Make filling robust against changing url by JavaScript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.h

Issue 2900713003: [Password Manager, merge to M-59] Make filling robust against changing url by JavaScript. (Closed)

Patch Set: fix merge Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/autofill/content/renderer/password_form_conversion_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_form_conversion_utils.h

diff --git a/components/autofill/content/renderer/password_form_conversion_utils.h b/components/autofill/content/renderer/password_form_conversion_utils.h

index 0529ac2c3d421677075ec0d598e5ecfd8aaea12a..8029c16cb9690f49f283b75a7fcaefebb2ae0791 100644

--- a/components/autofill/content/renderer/password_form_conversion_utils.h

+++ b/components/autofill/content/renderer/password_form_conversion_utils.h

@@ -68,6 +68,9 @@ bool HasAutocompleteAttributeValue(const blink::WebInputElement& element,

// the given |element| are present.

bool HasCreditCardAutocompleteAttributes(const blink::WebInputElement& element);

+// The "Realm" for the sign-on. This is scheme, host, port.

+std::string GetSignOnRealm(const GURL& origin);

} // namespace autofill

#endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_FORM_CONVERSION_UTILS_H__