src/objects-debug.cc - Issue 2900703002: [es2015] Precompute the descriptive string for symbols.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 2900703002: [es2015] Precompute the descriptive string for symbols. (Closed)

Patch Set: Address feedback. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index 8bab9289d671f464b7db4d1f8842c23e14c0565b..4a52ea6f75ef4f7278a30534a58183bcd73a93e9 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -275,6 +275,7 @@ void Symbol::SymbolVerify() {

CHECK(HasHashCode());

CHECK(Hash() > 0u);

CHECK(name()->IsUndefined(GetIsolate()) || name()->IsString());

+ CHECK(descriptive_string()->IsString());

}

« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »