src/builtins/arm64/builtins-arm64.cc - Issue 2900703002: [es2015] Precompute the descriptive string for symbols.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/arm64/builtins-arm64.cc

Issue 2900703002: [es2015] Precompute the descriptive string for symbols. (Closed)

Patch Set: Address feedback. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/arm64/builtins-arm64.cc

diff --git a/src/builtins/arm64/builtins-arm64.cc b/src/builtins/arm64/builtins-arm64.cc

index 7e96dc4fb3658f52886ad35af4050a7d753008cf..0e286fca696de390e5cfe13aac000699de4b17d7 100644

--- a/src/builtins/arm64/builtins-arm64.cc

+++ b/src/builtins/arm64/builtins-arm64.cc

@@ -298,12 +298,8 @@ void Builtins::Generate_StringConstructor(MacroAssembler* masm) {

// 3b. Convert symbol in x0 to a string.

__ Bind(&symbol_descriptive_string);

- {

- __ Drop(x2);

- __ Drop(1);

- __ Push(x0);

- __ TailCallRuntime(Runtime::kSymbolDescriptiveString);

- }

+ __ Ldr(x0, FieldMemOperand(x0, Symbol::kDescriptiveStringOffset));

+ // Fall through.

__ bind(&drop_frame_and_ret);

{

« no previous file with comments | « src/builtins/arm/builtins-arm.cc ('k') | src/builtins/builtins-symbol.cc » ('j') | no next file with comments »